Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] refactor: theme to CSS variables #15704

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Dec 2, 2024

Part of the design-system agnostic refactor.

This is a draft of how CSS variables will be setup and used throughout the grid.

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Dec 2, 2024
@mui-bot
Copy link

mui-bot commented Dec 2, 2024

Deploy preview: https://deploy-preview-15704--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 802c642

Copy link
Member

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion on the theme shape and how I would map the Material UI theme to it

packages/x-data-grid/src/constants/cssVariables.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants