Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree view] Dragging out all child nodes leaves the parent with expanded/collapsed indicator #15527

Closed
arminmeh opened this issue Nov 21, 2024 · 2 comments · Fixed by #15539
Closed

[tree view] Dragging out all child nodes leaves the parent with expanded/collapsed indicator #15527

arminmeh opened this issue Nov 21, 2024 · 2 comments · Fixed by #15539
Assignees
@flaviendelangle
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!

Comments

@arminmeh
Copy link
Contributor

arminmeh commented Nov 21, 2024 •
edited by github-actions bot
Loading

Steps to reproduce

Steps:

  1. Open Enable drag & drop re-ordering
  2. Drag one parent's children out of that parent

Current behavior

Expanded/Collapsed indicator stays with the former parent even when it becomes a regular item

Expected behavior

Expanded/Collapsed indicator should be removed once there are no children left

Context

No response

Your environment

No response

Search keywords: tree-view, drag-and-drop, ordering
@arminmeh arminmeh added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Nov 21, 2024
@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 21, 2024
@flaviendelangle
Copy link
Member

flaviendelangle commented Nov 21, 2024 •
edited
Loading

Thanks for the bug report 🙏
It seems to work fine after #14210 (doc preview) which will be released this week.
But we are still mutating the state which is far from ideal... even if it doesn't cause direct problem now.

@flaviendelangle flaviendelangle self-assigned this Nov 21, 2024
@flaviendelangle flaviendelangle mentioned this issue Nov 21, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TreeView] Remove state mutation in moveItemInTree flaviendelangle/mui-x
3 participants
@flaviendelangle @arminmeh @michelengelen