Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve chart SEO #10170

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[docs] Improve chart SEO #10170

merged 1 commit into from
Aug 30, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 29, 2023

Per the following search volume data, I think we should change the SEO title.

Screenshot 2023-08-29 at 13 41 12

https://app.ahrefs.com/keywords-explorer/list/new/db2c322fa1f3891b3d2c32da458fe4a5/google/us/overview

on this pages, and the other chart pages.

Preview: https://deploy-preview-10170--material-ui-x.netlify.app/x/react-charts/gantt/

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Aug 29, 2023
@oliviertassinari oliviertassinari force-pushed the oliviertassinari-patch-1 branch from 3c34590 to 387aa16 Compare August 29, 2023 11:47
@mui-bot
Copy link

mui-bot commented Aug 29, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10170--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -121.3 184.7 184.7 20.58 119.893
Sort 100k rows ms 861.6 2,045.1 1,777.3 1,545.68 396.65
Select 100k rows ms 837.9 1,018.3 934.3 940.72 58.923
Deselect 100k rows ms 161 315.2 230.4 243.2 61.764

Generated by 🚫 dangerJS against ff90933

@oliviertassinari oliviertassinari force-pushed the oliviertassinari-patch-1 branch from 387aa16 to 9c06a36 Compare August 29, 2023 11:49
Signed-off-by: Olivier Tassinari <[email protected]>
@oliviertassinari oliviertassinari force-pushed the oliviertassinari-patch-1 branch from 9c06a36 to ff90933 Compare August 29, 2023 11:50
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense with the pickers title
Would it make sense to change the data grid pages as well?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 29, 2023

Would it make sense to change the data grid pages as well?

@flaviendelangle I'm not sure, these make sense to me:

title: React Data Grid component

title: Data Grid - Pivoting


One downside of this change is that the title in the browser is a bit less helpful. I have explored if we could only change the SEO title, but I couldn't find something obviously simpler. Google also has runtime engines, so he could detect that the title after hydration is different. I have too many tabs open to be able to read the table title, I just look at the logos, so it might be enough.

Speaking of tabs experience optimization. @danilo-leal I guess we could change the favicon based on the docs page we are on

Screenshot 2023-08-29 at 16 42 17

with the new logos.

@oliviertassinari oliviertassinari merged commit 5e0aa1d into master Aug 30, 2023
@oliviertassinari oliviertassinari deleted the oliviertassinari-patch-1 branch August 30, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants