Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slotProps - panel - anchorEl types missing for mui-x-grid-pro #10133

Closed
2 tasks done
jbaccarelli-equinix opened this issue Aug 25, 2023 · 2 comments
Closed
2 tasks done
Labels
component: data grid This is the name of the generic UI component, not the React module!

Comments

@jbaccarelli-equinix
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:

Steps:
1.
2.
3.

Current behavior 😯

There is an data-grid demo/example in the project, located in docs/data/data-grid/filtering/CustomFilterPanelPosition.tsx

that shows how to use the anchorEl pattern to correctly place custom toolbar menus

slotProps={{
  panel: {
    anchorEl: filterButtonEl,
  },
  toolbar: {
    setFilterButtonEl,
  },
}}

This seems to not be replicated in the types for mui-x-grid-pro

Screenshot 2023-08-25 at 10 35 30

I've tried cleaning and installing all of the project's dependencies multiple times, and searching in the cloned mui-x repo for the types, mui-x-grid-pro simply doesn't have the anchorEl props extended into panel

Expected behavior 🤔

slotProps - panel - anchorEl works for mui-x-grid-pro the same as mui-x-grid

Context 🔦

No response

Your environment 🌎

No response

Order ID or Support key 💳 (optional)

No response

@jbaccarelli-equinix jbaccarelli-equinix added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 25, 2023
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Aug 25, 2023
@MBilalShafi
Copy link
Member

MBilalShafi commented Aug 28, 2023

I couldn't reproduce the issue with the latest version of the Grid, could you provide the environment details (npx @mui/envinfo) and a minimal reproduction test case with the latest version? This would help understand the issue better. 👷
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@MBilalShafi MBilalShafi added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 28, 2023
@jbaccarelli-equinix
Copy link
Author

I couldn't reproduce the issue with the latest version of the Grid, could you provide the environment details (npx @mui/envinfo) and a minimal reproduction test case with the latest version? This would help understand the issue better. 👷 A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

I see that if i try to reproduce it withing mui-x it doesn't happen, im not really sure how we got it to not work on our project, maybe some type override somewhere, but i can see it's not a library problem. Thanks!

@github-actions github-actions bot removed the status: waiting for author Issue with insufficient information label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants