Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Improve cherry-pick workflow #234

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

michelengelen
Copy link
Member

This handles 2 things:

  1. switches to a matrix approach to prevent consecutive PRs being opened. Now this workflow will not run a number of times for each PR merged, but rather once opening several cherry-pick PRs at once (if multiple targets are needed)
  2. add the reviewers from the original PR to the cherry-pick PR to improve workflow even more

@michelengelen michelengelen added enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes labels Nov 6, 2024
@michelengelen michelengelen self-assigned this Nov 6, 2024
@michelengelen
Copy link
Member Author

Sry @JCQuintas ... your comment resulted in an even better refactor! :P

Effectively removing the inheritance and assigning labels manually is better: https://github.com/carloscastrojumo/github-cherry-pick-action/blob/c980652a80bb76d11b6cdc38efb0a5cee28ff4e6/action.yml#L36-L39

That part is not documented in the README!

@michelengelen michelengelen removed the request for review from alexfauquette November 6, 2024 10:44
@michelengelen michelengelen merged commit 008ae93 into mui:master Nov 6, 2024
5 checks passed
@michelengelen michelengelen deleted the automation/matrix-approach branch November 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants