Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools-public] Update toolpad/studio to v^0.8.0 #229

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Nov 5, 2024

This toolpad/studio version uses Dashboard layout component from toolpad/core. mui/toolpad#4119

After this, same update to be done for tools-private.

Also removed the non-working Autocomplete:
Screenshot 2024-11-05 at 10 19 58 AM

@oliviertassinari oliviertassinari temporarily deployed to toolpad - mui-public-tools-public PR #229 November 5, 2024 07:19 — with Render Destroyed
@prakhargupta1 prakhargupta1 added the scope: tools Toolpad support apps label Nov 5, 2024
@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Nov 5, 2024

I don't know why the circleCI tests are failing. The Details button throws session expired and asks me to login (which is not the case for other repos)

@oliviertassinari oliviertassinari temporarily deployed to toolpad - mui-public-tools-public PR #229 November 8, 2024 12:09 — with Render Destroyed
@oliviertassinari oliviertassinari added the dependencies Update of dependencies label Nov 8, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 8, 2024

I don't know why the circleCI tests are failing. The Details button throws session expired and asks me to login (which is not the case for other repos)

@prakhargupta1 Are you able to

  1. See:
SCR-20241108-lvgr
  1. And then? https://app.circleci.com/pipelines/github/mui/mui-public/297/workflows/3ee64cc2-154b-4fb2-965a-0c2cd53533d5/jobs/774?

@oliviertassinari oliviertassinari merged commit 1485ddd into master Nov 8, 2024
8 checks passed
@oliviertassinari oliviertassinari deleted the toolpad branch November 8, 2024 12:13
@prakhargupta1
Copy link
Member Author

And then? https://app.circleci.com/pipelines/github/mui/mui-public/297/workflows/3ee64cc2-154b-4fb2-965a-0c2cd53533d5/jobs/774?

Ok, I could see it after logging into CircleCI which was rare as I don't have to login for other repositories.

Anyway, Thanks for merging.

https://tools-public.mui.com/prod/pages/OverviewPage now has the Dashboard Layout component from toolpad/core.

@oliviertassinari
Copy link
Member

I have run pnpm dedupe based on the step in CircleCI that failed and pushed the commit: fe9e68b. It was enough to make this pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies scope: tools Toolpad support apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants