Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Rename function #44542

Closed
wants to merge 1 commit into from
Closed

Conversation

MarcGoekce
Copy link

I found the easter egg Matt left us to find. Haha

I found the easter egg Matt left us to find. Haha

Signed-off-by: MarcGoekce <[email protected]>
@mui-bot
Copy link

mui-bot commented Nov 25, 2024

Netlify deploy preview

https://deploy-preview-44542--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b0c799f

@aarongarciah aarongarciah self-requested a review November 25, 2024 16:59
@aarongarciah
Copy link
Member

Hey @MarcGoekce, can you provide more feedback on why this change is needed? I don't understand what you mean by:

I found the easter egg Matt left us to find. Haha

@aarongarciah aarongarciah added the docs Improvements or additions to the documentation label Nov 25, 2024
@aarongarciah aarongarciah changed the title fix: renamed function from a11yProps to allyProps [docs] Rename function Nov 25, 2024
@aarongarciah aarongarciah added the package: material-ui Specific to @mui/material label Nov 25, 2024
@aarongarciah aarongarciah changed the title [docs] Rename function [material-ui][docs] Rename function Nov 25, 2024
@aarongarciah aarongarciah added the status: waiting for author Issue with insufficient information label Nov 25, 2024
@MarcGoekce
Copy link
Author

MarcGoekce commented Nov 26, 2024

I copied parts of the example from the docs and was confused when my IDE couldn't autocomplete the function allyProps. That caused me 30 seconds of brainpower to understand that it's a 1 and not a lowercase L.

When zoomed in, the difference is obvious, but in size 12 it's easy to overlook.

image
image

I don't understand what you mean by:

I found the easter egg Matt left us to find. Haha

This was no mistake by Matt. He probably left in for someone to find. Kind of like an easter egg irl. You can close this if you want to leave it like that. Discuss it with your team if you want to get their opinions 😄

@aarongarciah
Copy link
Member

Thanks for the clarification. "a11y" is a common abbreviation for "accessibility". We'll keep as is. Cheers.

@MarcGoekce
Copy link
Author

Oh now I understand. That's the first time I see the abbreviation for accessibility used in code. Now I feel silly for calling it allyProps.
Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material status: waiting for author Issue with insufficient information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants