Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Mention Toolpad in Example projects doc #44391

Closed
wants to merge 11 commits into from
Closed

[docs] Mention Toolpad in Example projects doc #44391

wants to merge 11 commits into from

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Nov 12, 2024 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Nov 12, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a07bc19

@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Nov 12, 2024
@prakhargupta1 prakhargupta1 marked this pull request as ready for review November 12, 2024 13:42
@samuelsycamore
Copy link
Contributor

If we add Toolpad here, then this sentence at the top of the doc is no longer technically true:

The following integration examples are available in the /examples folder of the Material UI GitHub repository. [...]

So if we want to proceed, I think we need to rewrite this whole section:

The following integration examples feature Material UI paired with other popular React libraries and frameworks, so you can skip the initial setup steps and jump straight into building.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 17, 2024 •
edited
Loading

On what's the right place for add Toolpad in the docs, it feels like it's the same case as #44315 (comment).

@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Nov 18, 2024 •
edited
Loading

So if we want to proceed, I think we need to rewrite this whole section:

Just did this change, but as per Olivier's PR we may want to put it under Related projects > App starters. I'll let you decide the placement that makes most sense.

Based on the discussion in Toolpad weekly call, we decided to just mention Toolpad in the Free templates section.

This was referenced Nov 26, 2024
Closed
Open
@prakhargupta1 prakhargupta1 changed the title [docs] Mention Toolpad in Example projects section [docs] Mention Toolpad in Example projects doc Nov 27, 2024
@prakhargupta1 @samuelsycamore
Update docs/data/material/getting-started/example-projects/example-pr…
d77b44c 
…ojects.md

Co-authored-by: Sycamore <[email protected]>
Signed-off-by: Prakhar Gupta <[email protected]>
@bharatkashyap
Copy link
Member

@prakhargupta1 I've added the change in the original PR (#44415) so that all Toolpad-related additions to the Material UI templates/examples pages can be a single commit when merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore left review comments

@oliviertassinari oliviertassinari oliviertassinari left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation Toolpad
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prakhargupta1 @mui-bot @samuelsycamore @oliviertassinari @bharatkashyap