Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom theme colors breaking MuiButton in Material UI v6 #43810

Closed
sprietNathanael opened this issue Sep 18, 2024 · 1 comment · Fixed by #43861
Closed

Custom theme colors breaking MuiButton in Material UI v6 #43810

sprietNathanael opened this issue Sep 18, 2024 · 1 comment · Fixed by #43861
Assignees
@siriwatknp
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! customization: theme Centered around the theming features priority: important This change can make a difference regression A bug, but worse v6.x

Comments

@sprietNathanael
Copy link

sprietNathanael commented Sep 18, 2024 •
edited by oliviertassinari
Loading

Steps to reproduce

Link to live example: not working with Material UI v6 but working with Material UI v5.

Steps:

  1. Create a custom palette colors
  2. Apply it on an Icon Button to check it works
  3. Apply it on a Button, this does not work

Current behavior

The color is not applied and the hover effect is broken

Expected behavior

The color should be applied and the hover effect working

Context

Add a custom color to the theme's palette and apply it to a button

Your environment

No response

Search keywords: theme colors button
@sprietNathanael sprietNathanael added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 18, 2024
@zannager zannager added the customization: theme Centered around the theming features label Sep 18, 2024
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work priority: important This change can make a difference regression A bug, but worse labels Sep 19, 2024
@oliviertassinari oliviertassinari changed the title Custom theme colors breaking MuiButton in MUI 6.1 Custom theme colors breaking MuiButton in Material UI v6 Sep 19, 2024
@siriwatknp siriwatknp added component: button This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 23, 2024
@siriwatknp siriwatknp mentioned this issue Sep 23, 2024
Merged
1 task
@siriwatknp siriwatknp moved this to In progress in Material UI Sep 23, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Material UI Sep 26, 2024
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @sprietNathanael! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! customization: theme Centered around the theming features priority: important This change can make a difference regression A bug, but worse v6.x
Projects
Material UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Button] ignore dark and contrastText if not provided in the theme siriwatknp/material-ui
4 participants
@oliviertassinari @sprietNathanael @siriwatknp @zannager