Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Button color="inherit" prop regression for variant="contained" #43741

Closed
snosenzo opened this issue Sep 13, 2024 · 1 comment · Fixed by #43862
Closed

[material-ui] Button color="inherit" prop regression for variant="contained" #43741

snosenzo opened this issue Sep 13, 2024 · 1 comment · Fixed by #43862
Assignees
Labels
component: button This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse v6.x

Comments

@snosenzo
Copy link

snosenzo commented Sep 13, 2024

Steps to reproduce

Link to live example: (required)

https://stackblitz.com/edit/github-rerofp?file=src%2FApp.js

Current behavior

Text in contained button is black.

Expected behavior

Text in contained button is hot-pink.

Context

Was upgrading to v6.0.0 and noticed this regression. I don't think it was documented anywhere, but I believe that is should if it was intentional.

Also FYI it looks like assigning color="" appears to give me the desired behavior, but definitely not an ideal workaround.

Thanks for taking a look!

Your environment

npx @mui/envinfo Used crhome ``` System: OS: macOS 13.4.1 Binaries: Node: 20.11.0 - /usr/local/bin/node npm: 10.2.4 - /usr/local/bin/npm pnpm: Not Found Browsers: Chrome: 128.0.6613.138 Edge: Not Found Safari: 16.5.1 npmPackages: @emotion/react: 11.13.3 @emotion/styled: 11.13.0 @mui/base: 5.0.0-beta.58 @mui/core-downloads-tracker: 6.0.2 @mui/icons-material: 6.0.0 @mui/lab: 5.0.0-alpha.166 @mui/material: 6.0.0 @mui/private-theming: 6.0.2 @mui/styled-engine: 6.0.2 @mui/styles: 6.0.0 @mui/system: 6.0.0 @mui/types: 7.2.16 @mui/utils: 5.15.11 @mui/x-data-grid: 6.20.4 @mui/x-data-grid-pro: 6.20.4 @mui/x-date-pickers: 6.20.2 @mui/x-license-pro: 6.10.2 => 6.10.2 @types/react: 18.3.5 react: 18.3.1 react-dom: 18.3.1 typescript: 5.4.5 => 5.4.5 ```

Search keywords: color, button, inherit, variant

@snosenzo snosenzo added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 13, 2024
@zannager zannager added the component: button This is the name of the generic UI component, not the React module! label Sep 13, 2024
@DiegoAndai DiegoAndai moved this to Backlog in Material UI Sep 13, 2024
@siriwatknp siriwatknp added regression A bug, but worse v6.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 16, 2024
@aarongarciah aarongarciah added the package: material-ui Specific to @mui/material label Sep 16, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title Button color="inherit" prop regression for variant="contained" [material-ui] Button color="inherit" prop regression for variant="contained" Sep 18, 2024
@siriwatknp siriwatknp moved this from Backlog to In progress in Material UI Sep 23, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Material UI Sep 23, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @snosenzo! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse v6.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants