Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tabs] Add min-width: '0' as default for TabPanel to help with CSS grid container #37280

Open
luan-dang-techlabs opened this issue May 12, 2023 · 7 comments
Assignees
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! package: lab Specific to @mui/lab ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@luan-dang-techlabs
Copy link

luan-dang-techlabs commented May 12, 2023

Summary 💡

Would like to have min-width: '0' as default for TabPanel so the GridDataPro layout doesn't overflow.

e.g. By using min-width: '0' with TabPanel, will fix the overflow issue with DataGridPro.

234352624-7f94a3fc-15d7-42df-8a54-96b76a0f32a8.mov

Examples 🌈

Reproduction: https://codesandbox.io/s/data-grid-community-forked-tsywms?file=/package.json

Motivation 🔦

Note: Please reference these Github issues that explains the details:
mui/mui-x#8547 (comment)

@luan-dang-techlabs luan-dang-techlabs added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 12, 2023
@zannager zannager transferred this issue from mui/material-ui May 15, 2023
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label May 15, 2023
@cherniavskii cherniavskii transferred this issue from mui/mui-x May 15, 2023
@cherniavskii cherniavskii removed the component: data grid This is the name of the generic UI component, not the React module! label May 15, 2023
@zannager zannager added the component: tabs This is the name of the generic UI component, not the React module! label May 15, 2023
@oliviertassinari oliviertassinari changed the title Add min-width: '0' as default for TabPanel to help with DataGridPro v6.4.0 Add min-width: '0' as default for TabPanel to help with CSS grid container May 16, 2023
@mnajdova

This comment was marked as resolved.

@mnajdova mnajdova added breaking change and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 29, 2023
@mnajdova mnajdova added this to the v6 milestone May 29, 2023
@oliviertassinari

This comment was marked as resolved.

@mnajdova

This comment was marked as resolved.

@TheBit

This comment was marked as resolved.

@oliviertassinari

This comment was marked as resolved.

@oliviertassinari oliviertassinari added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Jan 29, 2024
@oliviertassinari oliviertassinari changed the title Add min-width: '0' as default for TabPanel to help with CSS grid container [tabs] Add min-width: '0' as default for TabPanel to help with CSS grid container Jan 29, 2024
@yash49
Copy link
Contributor

yash49 commented Sep 17, 2024

Hey maintainers,

#37528 (review)

For me, the only consideration is it is MUI's components responsibility to have this style when developers are using CSS grid? If we add it to the tabs, where do we stop? In the data grid, we said yes out of convenience # 9179 with @ cherniavskii, but I wonder.

has this been decided whether it's MUI's responsibility to add such style or not?

If yes and it is MUI's responsibility
then I would like to work on this issue

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 17, 2024

Adding min-width: '0' would make sense for the CssBaseline component #38507 (item 6.) to have it on all elements.

However, we try to never force <CssBaseline> to developers as it can be a challenge when migrating to Material UI in an existing project (breaking unrelated things). So we tried to always make the component self-sustained, similar to the experience when adopting one component at a time from npm.

So it would make sense to me to make the same move here. I added the "ready to take" label but to make sure with the Material UI team that we want to move in this direction.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work and removed breaking change labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! package: lab Specific to @mui/lab ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants