Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Composite] Detect text direction in event handler instead #871

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[Composite] Detect text direction in event handler instead #871

merged 2 commits into from
Nov 26, 2024

Conversation

mj12albert
Copy link
Member

Part of #831

@mj12albert mj12albert added the core Infrastructure work going on behind the scenes label Nov 26, 2024
@mui-bot
Copy link

mui-bot commented Nov 26, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-871--base-ui.netlify.app/

Generated by 🚫 dangerJS against 636ed2c

@mj12albert mj12albert marked this pull request as ready for review November 26, 2024 05:35
@mj12albert mj12albert removed the request for review from colmtuite November 26, 2024 05:35
@mj12albert
Copy link
Member Author

@atomiks This is all of the lazy check we discussed yesterday right? (I'll do all the public components in a separate PR)

atomiks
atomiks approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is the lazy check. There's no need to cache it as it isn't expensive enough to care when it's just 1 in an event handler, Floating UI has read from it multiple times on every update for years and does ok.

@mj12albert mj12albert merged commit cf7bd37 into mui:master Nov 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj12albert @mui-bot @atomiks