Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing mini-fame doesn't work in 29.1? #78

Open
zck opened this issue Aug 22, 2023 · 9 comments
Open

Resizing mini-fame doesn't work in 29.1? #78

zck opened this issue Aug 22, 2023 · 9 comments

Comments

@zck
Copy link

zck commented Aug 22, 2023

I just upgraded to Emacs 29.1. Mini-frame works on its own, but when combined with Vertico (which also works on its own), it doesn't work anymore.

A screenshot is attached.

image

Reproduction instructions:

  1. Install Emacs 29.1
  2. Install vertico
(package-install-file "~/.emacs.d/elpa/vertico-1.4/vertico.el")
(vertico-mode 1)
  1. Test vertico with C-x C-f. It works properly; that is, I see vertical completions.
  2. Disable vertico
(vertico-mode -1)
  1. Install mini-frame
(package-install-file "~/.emacs.d/elpa/mini-frame-20220627.2041/mini-frame.el")
(mini-frame-mode 1)
  1. Test mini-frame with C-x C-f. It works properly; that is, I see the single option at the top of the frame.
  2. Enable vertico mode again.
(vertico-mode 1)
  1. Test with C-x C-f and see that it behaves weirdly. The look is as the screenshot above, and nothing is able to be selected. Pressing C-g several times in a row exits out of it, ususally.
@muffinmad
Copy link
Owner

Works for me. Just compiled recent Emacs 29 version and then in emacs -Q

  1. M-x package-initialize
  2. M-x vertico-mode
  3. M-x mini-frame-mode
  4. M-x
Screenshot 2023-08-23 at 00 51 31
GNU Emacs 29.1.50 (build 1, aarch64-apple-darwin22.5.0, NS appkit-2299.60 Version 13.4.1 (c) (Build 22F770820d))

@muffinmad
Copy link
Owner

@zck I've checked latest Emacs-mac build and see the same issue. But I can see the same behaviour without any packages just by using separate mini-buffer frame with resize-mini-frames turned on.

Can you please check if Emacs is working for you if you launch it like this:

emacs -Q --eval "(setq default-frame-alist '((minibuffer . nil)))" --eval "(setq resize-mini-frames t)"

@zck
Copy link
Author

zck commented Aug 30, 2023

Weird! When I do that, I get two windows open.

Screenshot from 2023-08-30 09-31-53

When I run C-x b, it looks like this:

image

@muffinmad
Copy link
Owner

It is ok that two windows are created because we told Emacs that default frame should not contain mini-buffer, so separate window is created.

What is not ok is that I can not use Emacs in this case. Emacs just hangs when pressing C-x C-f to open some file.

Can you change the buffer after C-x b or your Emacs is hanging too?

@zck
Copy link
Author

zck commented Aug 30, 2023

My emacs hangs as well.

@muffinmad
Copy link
Owner

Can you please report this issue to Emacs bugs tracker?

@KindlyRepeat
Copy link

Hi, using this command (omitting the second occurrence of --eval seems to fix the hanging:

emacs -Q --eval "(setq default-frame-alist '((minibuffer . nil))) (setq resize-mini-frames t)"

@muffinmad
Copy link
Owner

Hi, using this command (omitting the second occurrence of --eval seems to fix the hanging:

emacs -Q --eval "(setq default-frame-alist '((minibuffer . nil))) (setq resize-mini-frames t)"

The hanging is fixed because this way the resize-mini-frames variable is not set. You can check the variable value by C-h v resize-mini-frames.

@muffinmad muffinmad changed the title Mini-fame doesn't work with vertico in 29.1? Resizing mini-fame doesn't work in 29.1? Dec 5, 2023
@KindlyRepeat
Copy link

KindlyRepeat commented Dec 6, 2023

You're absolutely right, can't believe I didn't see that one.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants