Create tests for components defined as refs twice #96
Conversation
Yes it's good enough for the test, but I don't think this is what we want. So you could create a separate ticket to change that behaviour.
As you hinted, the only real way to get to internal information is through the If we don't have enough/easy internal information to check these kind of things, we might need to invest in things to improve this, like more/easier internal access, and/or utils to work with them, etc. Let me know if this is enough to get you going, or if I should start looking into it a bit more :)
Nice, although it surprises me that the Also, would be good to test some compound bindings, like adding different
I think this is more of a chapter for in the "Guide" area, and then mention and link it from the |
| expect(handleChildClickFromParent).toHaveBeenCalledTimes(1); | ||
| // bindings are applied from the child component like Child > Parent > Grandparent | ||
| // The final textContent should be the one defined in the grandparent | ||
| expect(child.textContent).toBe('text from grandparent'); |
There was a problem hiding this comment.
This could make use of the DOM matchers :)
There was a problem hiding this comment.
I had a hard time trying to install and configure jest-dom, could you help me with that please?
There was a problem hiding this comment.
I pushed a commit in your branch to make this work :)
issue here
I created this issue for ref component instance extraction
A few tests were added
I think it's better to finish the two new issues to be completely sure of what's going on before updating the docs |
|
We decided to not allow double refs on a single element, which has been enforced in #99 |
With this tests we're trying to solve some questions about defining child components as 'refs' in multiple parents.
@ThaNarie This is what I discovered so far and the questions I have
test if the component is only initialised once: I'm testing the mounting of the child component, it gets mounted once for each parent, is testing the mounting good enough?
test if both refs share the same component instance: I'm unsure how to test this, I could get the global muban instance to test if the child ref exists only once in the instance, does that make sense? the other solution is from the grandparent component look for the parent's child instance like, grandparent.__instance.refs.parent.__instance.refs.child.__instance.uid but feels hacky to me
what happens when using bindings from both places that DON'T overlap:
what happens when using bindings from both places that DO overlap:
what happens with component collections, that maybe partly overlap between parents and children:
The answer for this questions is the same, the bindings are applied from the child like Child > Parent > Grandparent, the grandparent bindings will always overwrite the parent's if they overlap, if they don't overlap then the child updates made by the parent bindings will be preserved, same rule applies to collections
After finishing the tests i still need to write the docs, do you think addding a new section to the component bindings docs is good enough 🍻