Feature/10 add usetimeout and useinterval hooks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThaNarie
requested changes
Apr 26, 2022
leroykorterink
requested changes
Apr 26, 2022
ThaNarie
reviewed
Apr 26, 2022
ThaNarie
reviewed
Apr 26, 2022
jspolancor
reviewed
Apr 27, 2022
| clearTimeout(handle); | ||
| } | ||
|
|
||
| onUnmounted(() => { |
There was a problem hiding this comment.
If onUnmounted expects a function definition maybe we could write it like:
onUnmounted(cancel)
There was a problem hiding this comment.
Generally I don't like these kind of optimisations:
- When not careful, you could lose scope of the passed function
- When not careful, you could be passing unwanted arguments to the passed function
- And some more subjective reasons, like clarity, and not having to add/remove the arrow function when wanting to add more lines, etc.
jspolancor
reviewed
Apr 27, 2022
| clearInterval(handle); | ||
| } | ||
|
|
||
| onUnmounted(() => { |
There was a problem hiding this comment.
Same as here
This could be
onUnmounted(stop)
ThaNarie
reviewed
Apr 29, 2022
ThaNarie
reviewed
Apr 29, 2022
…onsistent with the useInterval hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the following hooks:
useIntervaluseTimeoutand close #10