Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect URL #1

Open
senfo opened this issue Jul 3, 2013 · 1 comment
Open

Incorrect URL #1

senfo opened this issue Jul 3, 2013 · 1 comment

Comments

@senfo
Copy link

senfo commented Jul 3, 2013

Given the following:

var API = Phonebook.open({
url: '/',
options: {
dataType: 'json'
},
data: {}
});

API.addChapter({
name: 'events',
url: '/events'
});

API.events.get();

Phonebook will attempt a GET request to http://localhost/eventsundefined

Based on my understanding of the documentation (and expectations), I shouldn't have to pass the URL in the get() method, but I'm able to get around the issue by doing the following:

API.events.get('');

The get() function already has the chapters url at this point, but it doesn't look like it's using it.

@Akkuma
Copy link

Akkuma commented Jul 24, 2013

This is solved in my pull request #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants