From 0e370406e5049ff774cdde9cffc0afa8da506436 Mon Sep 17 00:00:00 2001
From: Deathwing777 <160651137+Deathwing777@users.noreply.github.com>
Date: Sat, 2 Nov 2024 16:07:33 -0700
Subject: [PATCH] Changed variable name per reviewer suggestion.

Variable changed from use_default_digilines_rules to enable_vertical_digilines_connectivity.
---
 common.lua           | 8 ++++----
 default_settings.lua | 2 +-
 settingtypes.txt     | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/common.lua b/common.lua
index 255da13..f12e530 100644
--- a/common.lua
+++ b/common.lua
@@ -17,12 +17,12 @@ pipeworks.rules_all = {{x=0, y=0, z=1},{x=0, y=0, z=-1},{x=1, y=0, z=0},{x=-1, y
 pipeworks.mesecons_rules={{x=0,y=0,z=1},{x=0,y=0,z=-1},{x=1,y=0,z=0},{x=-1,y=0,z=0},{x=0,y=1,z=0},{x=0,y=-1,z=0}}
 
 local digilines_enabled = minetest.get_modpath("digilines") ~= nil
-if digilines_enabled and pipeworks.use_default_digilines_rules then
+if digilines_enabled and pipeworks.enable_vertical_digilines_connectivity then
 	pipeworks.digilines_rules=digiline.rules.default
 else
-	-- When using these rules, digiline signals are NOT conducted vertically, despite any rotation to the node. This
-	-- breaks expected behavior with digiline conducting tubes. Some servers however, may have builds that relied on
-	-- the lack of vertical conduction and may wish to revert to this behavior.
+	-- These rules break vertical connectivity to deployers, node breakers, dispensers, and digiline filter injectors
+	-- via digiline conducting tubes. Changing them may break some builds on some servers, so the setting was added
+	-- for server admins to be able to revert to the old "broken" behavior as some builds may use it as a "feature".
 	-- See https://github.com/mt-mods/pipeworks/issues/64
 	pipeworks.digilines_rules={{x=0,y=0,z=1},{x=0,y=0,z=-1},{x=1,y=0,z=0},{x=-1,y=0,z=0},{x=0,y=1,z=0},{x=0,y=-1,z=0}}
 end
diff --git a/default_settings.lua b/default_settings.lua
index c4edf44..ccc091e 100644
--- a/default_settings.lua
+++ b/default_settings.lua
@@ -31,7 +31,7 @@ local settings = {
 	delete_item_on_clearobject = true,
 	use_real_entities = true,
 	entity_update_interval = 0,
-	use_default_digilines_rules = true,
+	enable_vertical_digilines_connectivity = true,
 }
 
 pipeworks.toggles = {}
diff --git a/settingtypes.txt b/settingtypes.txt
index 27054cc..88a6cfe 100644
--- a/settingtypes.txt
+++ b/settingtypes.txt
@@ -92,7 +92,7 @@ pipeworks_entity_update_interval (Entity Update Interval) float 0 0 0.8
 # or bottom faces, regardless of the node rotation. This breaks expected behavior with digiline
 # conducting tubes, so it is recommended to enable this option unless you have specific builds
 # that make use of the lack of vertical digiline connectivity and those are more important to you.
-pipeworks_use_default_digilines_rules (Use the default rules from the digilines mod) bool true
+enable_vertical_digilines_connectivity (Use the default rules from the digilines mod) bool true
 
 # if set to true, items passing through teleport tubes will log log where they came from and where they went.
 pipeworks_log_teleport_tubes (Log Teleport Tubes) bool false