From 6ef9686b72a4c5293ef3e7b46d68eb09a99c19ec Mon Sep 17 00:00:00 2001
From: Michael Strelan <mstrelan@gmail.com>
Date: Wed, 8 May 2024 09:21:52 +1000
Subject: [PATCH] PHPUnit 10 support (#34)

* Set PHPUnit env vars in docker instead of phpunit.xml

* Remove phpunit.xml and update phpstorm config to use phpunit.xml.dist from core

* Update README to include core phpunit config

* BROWSERTEST_OUTPUT_VERBOSE=true

* Add env vars to dist
---
 .env.dist                     | 11 +++++--
 README.md                     |  2 +-
 assets/scaffold/files/php.xml |  2 +-
 docker-compose.yml            |  6 +++-
 phpunit.xml                   | 62 -----------------------------------
 5 files changed, 16 insertions(+), 67 deletions(-)
 delete mode 100644 phpunit.xml

diff --git a/.env.dist b/.env.dist
index b8ca3ae..ff63541 100644
--- a/.env.dist
+++ b/.env.dist
@@ -7,9 +7,16 @@ BASE_URI=http://127.0.0.1:8080
 UID=1000
 GID=1000
 
+# PHPUnit
+SIMPLETEST_BASE_URL=http://127.0.0.1:8080
+SIMPLETEST_DB=mysql://local:local@127.0.0.1/local
+BROWSERTEST_OUTPUT_DIRECTORY=/tmp
+BROWSERTEST_OUTPUT_BASE_URL=${BASE_URI}
+BROWSERTEST_OUTPUT_VERBOSE=true
+
 # CHROME DRIVER
-# SELENIUM_IMAGE=drupalci/chromedriver:production
-# MINK_DRIVER_ARGS_WEBDRIVER='["chrome", {"browserName":"chrome","goog:chromeOptions":{"args":["--headless", "--disable-gpu", "--no-sandbox", "--disable-dev-shm-usage"]}}, "http://127.0.0.1:9515"]'
+SELENIUM_IMAGE=drupalci/chromedriver:production
+MINK_DRIVER_ARGS_WEBDRIVER='["chrome", {"browserName":"chrome","goog:chromeOptions":{"args":["--headless", "--disable-gpu", "--no-sandbox", "--disable-dev-shm-usage"]}}, "http://127.0.0.1:9515"]'
 
 ## SELENIUM CHROME
 # SELENIUM_IMAGE=selenium/standalone-chrome:111.0
diff --git a/README.md b/README.md
index dc18bd5..22ac514 100644
--- a/README.md
+++ b/README.md
@@ -72,7 +72,7 @@ Alternatively you can run phpunit on the command line like so:
 
 ```
 docker-compose exec php-cli bash
-phpunit app/core/tests/Drupal/Tests/Core/DrupalKernel/
+phpunit -c app/core/phpunit.xml.dist app/core/tests/Drupal/Tests/Core/DrupalKernel/
 ```
 
 ## Debugging
diff --git a/assets/scaffold/files/php.xml b/assets/scaffold/files/php.xml
index e53ff53..368bcb9 100644
--- a/assets/scaffold/files/php.xml
+++ b/assets/scaffold/files/php.xml
@@ -15,7 +15,7 @@
   </component>
   <component name="PhpUnit">
     <phpunit_settings>
-      <phpunit_by_interpreter interpreter_id="f58849c8-e0cd-4acc-973b-98da73eaafb1" configuration_file_path="/data/phpunit.xml" custom_loader_path="/data/vendor/autoload.php" phpunit_phar_path="" use_configuration_file="true" />
+      <phpunit_by_interpreter interpreter_id="f58849c8-e0cd-4acc-973b-98da73eaafb1" configuration_file_path="/data/app/core/phpunit.xml.dist" custom_loader_path="/data/vendor/autoload.php" phpunit_phar_path="" use_configuration_file="true" />
     </phpunit_settings>
   </component>
 </project>
diff --git a/docker-compose.yml b/docker-compose.yml
index beb4bc7..cc97772 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -41,9 +41,13 @@ services:
     network_mode: service:nginx
     environment:
       - DRUSH_OPTIONS_URI=${BASE_URI:-http://127.0.0.1:8080}
+      - PHP_IDE_CONFIG=serverName=localhost
+      - SIMPLETEST_BASE_URL=${SIMPLETEST_BASE_URL:-http://127.0.0.1:8080}
+      - SIMPLETEST_DB=${SIMPLETEST_DB:-mysql://local:local@127.0.0.1/local}
+      - BROWSERTEST_OUTPUT_DIRECTORY=${BROWSERTEST_OUTPUT_DIRECTORY:-/tmp}
       - BROWSERTEST_OUTPUT_BASE_URL=${BASE_URI:-http://127.0.0.1:8080}
+      - BROWSERTEST_OUTPUT_VERBOSE=${BROWSERTEST_OUTPUT_VERBOSE:-true}
       - MINK_DRIVER_ARGS_WEBDRIVER
-      - PHP_IDE_CONFIG=serverName=localhost
     volumes:
       - ./:/data
       - ./.docker/php/custom.ini:/etc/php/conf.d/99-custom.ini
diff --git a/phpunit.xml b/phpunit.xml
deleted file mode 100644
index 9b60293..0000000
--- a/phpunit.xml
+++ /dev/null
@@ -1,62 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<phpunit bootstrap="app/core/tests/bootstrap.php" colors="true"
-         beStrictAboutTestsThatDoNotTestAnything="true"
-         beStrictAboutOutputDuringTests="true"
-         beStrictAboutChangesToGlobalState="true"
-         failOnWarning="true"
-         printerClass="\Drupal\Tests\Listeners\HtmlOutputPrinter"
-         cacheResult="false"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
-  <php>
-    <ini name="error_reporting" value="32767"/>
-    <ini name="memory_limit" value="-1"/>
-    <env name="SIMPLETEST_BASE_URL" value="http://127.0.0.1:8080"/>
-    <env name="SIMPLETEST_DB" value="mysql://local:local@127.0.0.1/local"/>
-    <env name="BROWSERTEST_OUTPUT_DIRECTORY" value="/tmp"/>
-    <env name="BROWSERTEST_OUTPUT_BASE_URL" value="http://127.0.0.1:8080"/>
-    <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/>
-    <env name="MINK_DRIVER_CLASS" value=""/>
-    <env name="MINK_DRIVER_ARGS" value=""/>
-    <env name="MINK_DRIVER_ARGS_WEBDRIVER" value='["chrome", {"browserName":"chrome", "goog:chromeOptions":{"args":["--headless", "--no-sandbox", "--disable-dev-shm-usage"], "w3c": false}}, "http://127.0.0.1:4444/wd/hub"]'/>
-  </php>
-  <testsuites>
-    <testsuite name="unit">
-      <file>./app/core/tests/TestSuites/UnitTestSuite.php</file>
-    </testsuite>
-    <testsuite name="kernel">
-      <file>./app/core/tests/TestSuites/KernelTestSuite.php</file>
-    </testsuite>
-    <testsuite name="functional">
-      <file>./app/core/tests/TestSuites/FunctionalTestSuite.php</file>
-    </testsuite>
-    <testsuite name="functional-javascript">
-      <file>./app/core/tests/TestSuites/FunctionalJavascriptTestSuite.php</file>
-    </testsuite>
-    <testsuite name="build">
-      <file>./app/core/tests/TestSuites/BuildTestSuite.php</file>
-    </testsuite>
-  </testsuites>
-  <listeners>
-    <listener class="\Drupal\Tests\Listeners\DrupalListener">
-    </listener>
-  </listeners>
-  <!-- Filter for coverage reports. -->
-  <coverage>
-    <include>
-      <directory>./app/core/includes</directory>
-      <directory>./app/core/lib</directory>
-      <directory>./app/core/modules</directory>
-      <directory>./app/modules</directory>
-      <directory>./app/core/sites</directory>
-    </include>
-    <exclude>
-      <directory>./app/core/modules/*/src/Tests</directory>
-      <directory>./app/core/modules/*/tests</directory>
-      <directory>./app/core/modules/*/src/Tests</directory>
-      <directory>./app/core/modules/*/tests</directory>
-      <directory>./app/core/modules/*/*/src/Tests</directory>
-      <directory>./app/core/modules/*/*/tests</directory>
-    </exclude>
-  </coverage>
-</phpunit>