-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing without --locked fails to compile, errors related to FromBytes / AsBytes / Unaligned #341
Comments
Actually no. |
I'm also experiencing this issue, currently running this if it helps
I could also compile it directly with a local clone of the repo |
The following pattern only compiles when the
It breaks as soon as any dependency in the workspace enables the This feels like a bit of a footgun in zerocopy. I will need to re-release multiple crates to fix this. For now, you can work around this by passing |
I just want to add, that the current lock file has yanked dependencies and cargo advices not to install with --locked:
|
pe-unwind-info on the main branch has since been updated and does not have multiple definition of FromBytes / AsBytes Unaligned anymore. See mozilla/pe-unwind-info@7825141 Updating pe-unwind-info to 0.3.X should fix this issue. |
i landed here using wholesym 0.7.0 as a library, independently of samply (thanks for the crate btw!). I get a related compile error in samply-symbols:
i can confirm that this error is also fixed by your dep upgrades in HEAD. zerocopy does have a related bug report, which they considered to be a documentation problem: google/zerocopy#1587 it might be a good idea to update breakpad/index.rs to follow their recommendation though? otherwises this might creep back in via other dependencies in the closure. i tried a patch against wholesym-v0.7.0 in my workspace and it also fixed the error. i can send a PR if you like (it's just a one-liner). |
Ah, thanks, I've put up a PR to do this in #437. |
This is probably pe-unwind-info breakage, but trying to
cargo install samply
(or direct from source):The text was updated successfully, but these errors were encountered: