dts: msm8952: Add support for HMD Global Nokia 5 #450
Conversation
Documentation/devices.md
Outdated
| - HMD Global Nokia 6 (ple) | ||
| - HMD Global Nokia 5 (nd1) |
There was a problem hiding this comment.
| - HMD Global Nokia 6 (ple) | |
| - HMD Global Nokia 5 (nd1) | |
| - HMD Global Nokia 5 (nd1) | |
| - HMD Global Nokia 6 (ple) |
lk2nd/device/dts/msm8952/rules.mk
Outdated
| $(LOCAL_DIR)/msm8937-nokia-ple.dtb \ | ||
| $(LOCAL_DIR)/msm8937-nokia-nd1.dtb \ |
There was a problem hiding this comment.
| $(LOCAL_DIR)/msm8937-nokia-ple.dtb \ | |
| $(LOCAL_DIR)/msm8937-nokia-nd1.dtb \ | |
| $(LOCAL_DIR)/msm8937-nokia-nd1.dtb \ | |
| $(LOCAL_DIR)/msm8937-nokia-ple.dtb \ |
| &lk2nd { | ||
| nd1 { |
There was a problem hiding this comment.
| &lk2nd { | |
| nd1 { | |
| &lk2nd { | |
| nokia-nd1 { |
There was a problem hiding this comment.
I'd say it's fine to use either, seems like ple just has codename which is probably fine for case like this, where the msm/board id is mostly device specific anyway
|
For sure we would like to add more devices to lk2nd, so we can add NixOS stuffs later. |
|
Maybe we could add the necessary dependencies for NixOS in Documentation/building.md later. For now, I’ve fixed the commit to remove those flake files. What do you think? |
There was a problem hiding this comment.
wrt nixos configs: I definitely welcome extra build documentation in the Documentation dir, but I'm not so sure about the nix-specific files in the root...
I don't exactly know much about nix/nixos but per my understanding those files would lock down the toolchain version to whatever is shipped today in nixos, which is something that I don't quite like: i.e. if our code has issues that would've been found by newer gcc, they will be missed by those who use nix since I feel like no one would be updating those lock files. (on top of that, it's a bit unfortunate this seems to only specify x86_64 as I and perhaps few other people working on lk2nd do it on aarch64 machines at times :)
| &lk2nd { | ||
| nd1 { |
There was a problem hiding this comment.
I'd say it's fine to use either, seems like ple just has codename which is probably fine for case like this, where the msm/board id is mostly device specific anyway
| gpio-keys { | ||
| compatible = "gpio-keys"; | ||
| up { | ||
| lk2nd,code = <KEY_VOLUMEUP>; | ||
| gpios = <&tlmm 91 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
If you say the keys are inverted, perhaps you can configure both volume up and down here, and assign resin (or whatever's the default for 8952) to up, with gpio91 being down?
There was a problem hiding this comment.
I been trying buttons configurations for a few hours, but none worked. I resolved the issue adding some invert code on keys.c it worked flawless.
There was a problem hiding this comment.
no. if you've established that vol- is gpio 92, then put gpio 92 as vol- and explicitly define vol+ as resin - gpios = <&pmic_pon GPIO_PMIC_RESIN 0>; I think
There was a problem hiding this comment.
Thanks, that worked.
There was a problem hiding this comment.
I mistakenly used gpio 91 as UP when on was clearly as DOWN on downstream
andrewgigena
force-pushed
the
main
branch
2 times, most recently
from
246b3b1
to
7c98ad6
Compare
| up { | ||
| lk2nd,code = <KEY_VOLUMEUP>; | ||
| gpios = <&pmic_pon GPIO_PMIC_RESIN 0>; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Indentation seems to be broken now, let's keep it consistent (8-wide hard tabs)
|
|
||
| power { | ||
| lk2nd,code = <KEY_POWER>; | ||
| gpios = <&pmic_pon GPIO_PMIC_PWRKEY 0>; |
There was a problem hiding this comment.
Do you need this? should be the default...
There was a problem hiding this comment.
No, I added it to be certain
|
Thanks! |
|
Thanks a lot, @TravMurav and @wonderfulShrineMaidenOfParadise |
This pull request adds device tree support for the HMD Global Nokia 5 (nd1) on the msm8952 platform. Also, I added the necessary tools to the build lk2nd over NixOS. Same issue as Nokia 6 lk2nd port: “The only weird thing I've noticed is that the volume keys are swapped around.”
Screenshot working:
I have been able to boot mainstream successfully.
