Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IExceptionFilter members different from documentation #54

Open
glenhboonzaier opened this issue Oct 24, 2016 · 0 comments
Open

IExceptionFilter members different from documentation #54

glenhboonzaier opened this issue Oct 24, 2016 · 0 comments

Comments

@glenhboonzaier
Copy link

glenhboonzaier commented Oct 24, 2016

According to the documentation:

public class RollbarExceptionFilter : IExceptionFilter
{
    public void OnException(ExceptionContext filterContext)
    {
        if (filterContext.ExceptionHandled)
            return;

        (new RollbarClient()).SendException(filterContext.Exception);
    }
}

However, IExceptionFilter requires the following methods:

public bool AllowMultiple { get; }

public Task ExecuteExceptionFilterAsync(HttpActionExecutedContext actionExecutedContext, CancellationToken cancellationToken)
{
    throw new System.NotImplementedException();
}

Please update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant