-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with User IP and X-Forwarded-By #46
Labels
Comments
@olaj I use AWS, and AWS does use this pattern
Source: X-Forwarded Headers for Elastic Load Balancing In this case I guess that cloudflare use the same pattern, so we could use the first IP address instead the last one. Could you fix that? If yes, doesn't forget the unit tests 😛 |
actually CloudFlare passes the correct user IP Address in it's own header. so, just to include CF the code should also have:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure how to fix this but this method.
Didn't work well with my setup with Cloudflare. My header was like this.
Where the first one is the "good ip" and the second one is from Cloudflare. RollbarSharp was taking the last one and Rollbar didn't even accept that as an IP (because of the port i guess) and well it's the Cloudflare IP anyway so not that interesting. Just wanted to let you know. I run with a fork now where i take the first IP instead.
The text was updated successfully, but these errors were encountered: