Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SASS #127

Open
Overload119 opened this issue Oct 11, 2020 · 2 comments
Open

Support for SASS #127

Overload119 opened this issue Oct 11, 2020 · 2 comments

Comments

@Overload119
Copy link

Overload119 commented Oct 11, 2020 •
edited
Loading

Can we get SASS support in this Extension?

  • VS Code Version: August 2020
  • SCSS IntelliSense Version: Latest
  • Operating System: MAC OSX

Reproducible Case:

Open any SASS file.

Steps to Reproduce:

  1. No symbols work.

$40 via PayPal to whoever implements this :)
@rob4226
Copy link

rob4226 commented Nov 4, 2020

+1 Being able to use indented syntax in .sass files would be awesome.

@forivall
Copy link

forivall commented May 20, 2021 •
edited
Loading

Would depend on sass/dart-sass#88, as it's not getting in vscode-css-languageservice (microsoft/vscode-css-languageservice#158). I did find a parser at https://github.com/tonyganch/gonzales-pe, but it would need some work to be able to emit a usable ast structure.

ctsstc added a commit to LogicHappens/musical-conquest that referenced this issue Nov 7, 2021
@ctsstc
Show current version somewhere
19f762a 
Fixes #41

Updates redundant styles to a new container in index. I like the component not owning the styling as well. The container in index also handles flex styling on the children elements that are contained.

Remove sass from prettier because it doesn't support sass 🤯

Relevant Discord Chat:
found out while digging a few things that even though sass and scss are super close there's a lot less tooling and underlying architecture issues that lacks sass support :' (
I guess prettier doesn't support it; and likely because of these other underlying issues, I guess google is running the dart sass team but doesn't have time to do what we all need : (
prettier/prettier#4948
mrmlnc/vscode-scss#127
sass/dart-sass#88
Interesting long technical read though
TLDR; needs to have support for ASTs which allow code tools to help code; dart has no easy way to expose it
It's finally on a roadmap but then they said they won't ever get to it lol
classic product things
@ctsstc ctsstc mentioned this issue Nov 7, 2021
Merged
ctsstc added a commit to LogicHappens/musical-conquest that referenced this issue Nov 7, 2021
@ctsstc
Show current version somewhere
918790d 
Fixes #41

Updates redundant styles to a new container in index. I like the component not owning the styling as well. The container in index also handles flex styling on the children elements that are contained.

Remove sass from prettier because it doesn't support sass 🤯

Relevant Discord Chat:
found out while digging a few things that even though sass and scss are super close there's a lot less tooling and underlying architecture issues that lacks sass support :' (
I guess prettier doesn't support it; and likely because of these other underlying issues, I guess google is running the dart sass team but doesn't have time to do what we all need : (
prettier/prettier#4948
mrmlnc/vscode-scss#127
sass/dart-sass#88
Interesting long technical read though
TLDR; needs to have support for ASTs which allow code tools to help code; dart has no easy way to expose it
It's finally on a roadmap but then they said they won't ever get to it lol
classic product things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@forivall @Overload119 @rob4226