From d8ce8098baab652c8f3274150ae12a3beafa697f Mon Sep 17 00:00:00 2001
From: Makio64 <davronai@gmail.com>
Date: Wed, 9 Oct 2024 21:15:13 +0200
Subject: [PATCH 1/2] Refactor GridHelper to support different size and
 divisions

---
 src/helpers/GridHelper.js | 61 ++++++++++++++++++++++++++++++++-------
 1 file changed, 50 insertions(+), 11 deletions(-)

diff --git a/src/helpers/GridHelper.js b/src/helpers/GridHelper.js
index 68f4dadd3e8b2c..dc242bacded7b5 100644
--- a/src/helpers/GridHelper.js
+++ b/src/helpers/GridHelper.js
@@ -11,23 +11,62 @@ class GridHelper extends LineSegments {
 		color1 = new Color( color1 );
 		color2 = new Color( color2 );
 
-		const center = divisions / 2;
-		const step = size / divisions;
-		const halfSize = size / 2;
+		let sizeX, sizeZ;
+		if ( Array.isArray( size ) ) {
+
+			sizeX = size[ 0 ];
+			sizeZ = size[ 1 ];
+
+		} else {
+
+			sizeX = size;
+			sizeZ = size;
+
+		}
+
+		let divisionsX, divisionsZ;
+		if ( Array.isArray( divisions ) ) {
+
+			divisionsX = divisions[ 0 ];
+			divisionsZ = divisions[ 1 ];
+
+		} else {
+
+			divisionsX = divisions;
+			divisionsZ = divisions;
+
+		}
+
+		const centerX = divisionsX / 2;
+		const centerZ = divisionsZ / 2;
+
+		const stepX = sizeX / divisionsX;
+		const stepZ = sizeZ / divisionsZ;
+
+		const halfSizeX = sizeX / 2;
+		const halfSizeZ = sizeZ / 2;
 
 		const vertices = [], colors = [];
 
-		for ( let i = 0, j = 0, k = - halfSize; i <= divisions; i ++, k += step ) {
+		for ( let i = 0, k = - halfSizeZ; i <= divisionsZ; i ++, k += stepZ ) {
+
+			vertices.push( - halfSizeX, 0, k, halfSizeX, 0, k );
+
+			const color = ( i === centerZ ) ? color1 : color2;
+
+			color.toArray( colors, colors.length );
+			color.toArray( colors, colors.length );
+
+		}
+
+		for ( let i = 0, k = - halfSizeX; i <= divisionsX; i ++, k += stepX ) {
 
-			vertices.push( - halfSize, 0, k, halfSize, 0, k );
-			vertices.push( k, 0, - halfSize, k, 0, halfSize );
+			vertices.push( k, 0, - halfSizeZ, k, 0, halfSizeZ );
 
-			const color = i === center ? color1 : color2;
+			const color = ( i === centerX ) ? color1 : color2;
 
-			color.toArray( colors, j ); j += 3;
-			color.toArray( colors, j ); j += 3;
-			color.toArray( colors, j ); j += 3;
-			color.toArray( colors, j ); j += 3;
+			color.toArray( colors, colors.length );
+			color.toArray( colors, colors.length );
 
 		}
 

From 33e45590fd2e940f0a4b78cdae26cd4971c35647 Mon Sep 17 00:00:00 2001
From: Makio64 <davronai@gmail.com>
Date: Fri, 11 Oct 2024 08:51:25 +0200
Subject: [PATCH 2/2] reduce the code

---
 src/helpers/GridHelper.js | 60 ++++++++++-----------------------------
 1 file changed, 15 insertions(+), 45 deletions(-)

diff --git a/src/helpers/GridHelper.js b/src/helpers/GridHelper.js
index dc242bacded7b5..dc8f15a3a6ebb9 100644
--- a/src/helpers/GridHelper.js
+++ b/src/helpers/GridHelper.js
@@ -11,60 +11,33 @@ class GridHelper extends LineSegments {
 		color1 = new Color( color1 );
 		color2 = new Color( color2 );
 
-		let sizeX, sizeZ;
-		if ( Array.isArray( size ) ) {
+		const [ width, depth ] = Array.isArray( size ) ? size : [ size, size ];
+		const [ divisionsX, divisionsZ ] = Array.isArray( divisions ) ? divisions : [ divisions, divisions ];
 
-			sizeX = size[ 0 ];
-			sizeZ = size[ 1 ];
-
-		} else {
-
-			sizeX = size;
-			sizeZ = size;
-
-		}
-
-		let divisionsX, divisionsZ;
-		if ( Array.isArray( divisions ) ) {
-
-			divisionsX = divisions[ 0 ];
-			divisionsZ = divisions[ 1 ];
-
-		} else {
-
-			divisionsX = divisions;
-			divisionsZ = divisions;
-
-		}
-
-		const centerX = divisionsX / 2;
-		const centerZ = divisionsZ / 2;
-
-		const stepX = sizeX / divisionsX;
-		const stepZ = sizeZ / divisionsZ;
-
-		const halfSizeX = sizeX / 2;
-		const halfSizeZ = sizeZ / 2;
+		const stepX = width / divisionsX;
+		const stepZ = depth / divisionsZ;
+		const halfWidth = width / 2;
+		const halfDepth = depth / 2;
 
 		const vertices = [], colors = [];
 
-		for ( let i = 0, k = - halfSizeZ; i <= divisionsZ; i ++, k += stepZ ) {
+		for ( let i = 0; i <= divisionsZ; i ++ ) {
 
-			vertices.push( - halfSizeX, 0, k, halfSizeX, 0, k );
-
-			const color = ( i === centerZ ) ? color1 : color2;
+			const k = - halfDepth + i * stepZ;
+			vertices.push( - halfWidth, 0, k, halfWidth, 0, k );
 
+			const color = ( i === divisionsZ / 2 ) ? color1 : color2;
 			color.toArray( colors, colors.length );
 			color.toArray( colors, colors.length );
 
 		}
 
-		for ( let i = 0, k = - halfSizeX; i <= divisionsX; i ++, k += stepX ) {
-
-			vertices.push( k, 0, - halfSizeZ, k, 0, halfSizeZ );
+		for ( let i = 0; i <= divisionsX; i ++ ) {
 
-			const color = ( i === centerX ) ? color1 : color2;
+			const k = - halfWidth + i * stepX;
+			vertices.push( k, 0, - halfDepth, k, 0, halfDepth );
 
+			const color = ( i === divisionsX / 2 ) ? color1 : color2;
 			color.toArray( colors, colors.length );
 			color.toArray( colors, colors.length );
 
@@ -74,9 +47,7 @@ class GridHelper extends LineSegments {
 		geometry.setAttribute( 'position', new Float32BufferAttribute( vertices, 3 ) );
 		geometry.setAttribute( 'color', new Float32BufferAttribute( colors, 3 ) );
 
-		const material = new LineBasicMaterial( { vertexColors: true, toneMapped: false } );
-
-		super( geometry, material );
+		super( geometry, new LineBasicMaterial( { vertexColors: true, toneMapped: false } ) );
 
 		this.type = 'GridHelper';
 
@@ -91,5 +62,4 @@ class GridHelper extends LineSegments {
 
 }
 
-
 export { GridHelper };