Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use incidence accessors instead of bracket notation #65

Closed
zkamvar opened this issue May 28, 2019 · 0 comments · Fixed by #79
Closed

Use incidence accessors instead of bracket notation #65

zkamvar opened this issue May 28, 2019 · 0 comments · Fixed by #79

Comments

@zkamvar
Copy link
Collaborator

zkamvar commented May 28, 2019

We are currently discussing changing the structure of incidence objects in the future (reconhub/incidence#104), which will use on-the-fly computation of incidence alongside pre-computed. To handle this, it would be a good idea to use the get_counts() accessor for incidence instead of the bracket notation in functions like calc_incidence_per_time_step()
zkamvar added a commit that referenced this issue Jun 28, 2019
@zkamvar
use get_counts instead of $counts for incidence
5f0778a 
This will fix #65 and protect against changes in the internal
representations of incidence objects
@zkamvar zkamvar mentioned this issue Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 65 mrc-ide/EpiEstim
1 participant
@zkamvar