From 4ec776172a47341470fc6acbaeb6f31d4f4de6f9 Mon Sep 17 00:00:00 2001
From: Mateusz Pusz <mateusz.pusz@gmail.com>
Date: Sat, 16 Nov 2024 18:30:46 +0100
Subject: [PATCH] fix: alternative implementation for `IsOfCharacter`

---
 .../mp-units/framework/representation_concepts.h   | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/core/include/mp-units/framework/representation_concepts.h b/src/core/include/mp-units/framework/representation_concepts.h
index bb3a4f71e..d46d33fd5 100644
--- a/src/core/include/mp-units/framework/representation_concepts.h
+++ b/src/core/include/mp-units/framework/representation_concepts.h
@@ -80,12 +80,18 @@ template<typename T>
 concept Tensor = is_tensor<T>;
 
 template<typename T, quantity_character Ch>
-constexpr bool IsOfCharacterImpl =
-  (Ch == quantity_character::scalar && is_scalar<T>) || (Ch == quantity_character::complex && is_complex<T>) ||
-  (Ch == quantity_character::vector && is_vector<T>) || (Ch == quantity_character::tensor && is_tensor<T>);
+constexpr bool is_of_character_impl = false;
+template<typename T>
+constexpr bool is_of_character_impl<T, quantity_character::scalar> = is_scalar<T>;
+template<typename T>
+constexpr bool is_of_character_impl<T, quantity_character::complex> = is_complex<T>;
+template<typename T>
+constexpr bool is_of_character_impl<T, quantity_character::vector> = is_vector<T>;
+template<typename T>
+constexpr bool is_of_character_impl<T, quantity_character::tensor> = is_tensor<T>;
 
 template<typename T, quantity_character Ch>
-concept IsOfCharacter = IsOfCharacterImpl<T, Ch>;
+concept IsOfCharacter = is_of_character_impl<T, Ch>;
 
 template<typename T>
 using scaling_factor_type_t = conditional<treat_as_floating_point<T>, long double, std::intmax_t>;