-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emulation for pledge with seccomp #271
Conversation
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 1 1
Lines 507 507
=======================================
Hits 459 459
Misses 48 48 Continue to review full report at Codecov.
|
Thanks a great start @DBOTW! See #273, I wonder if we instead of /cc @DBOTW @mike-burns @calleerlandsson |
Oh wow this is cool as heck! And I do agree that #273 is probably the right direction for this project but I wonder whether something like this pledge implementation belongs in libbsd. Also it was illuminating to me to see pledge defined in terms of seccomp. I'm not qualified to have detected non-obvious bugs in this code. |
Thanks @mptre and @mike-burns, but this was just a quick hack based on
This is probably not the right approach when it comes to "security": by adding Even worse: I'm using So I'm concerned about the patch (that said I'm also not qualified for this) ... |
OK, not that bad: I have removed The new patch contains only the minimum of necessary rules to run Patch for the new sandbox-layer is in progress ... |
Closing this in favor of #274 ... |
... for #269 ... it's horrible but compiles and seems to work ... needs some more testing ...