Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID3v2.4 chapter images don't work #20

Open
Quppa opened this issue Apr 18, 2024 · 4 comments
Open

ID3v2.4 chapter images don't work #20

Quppa opened this issue Apr 18, 2024 · 4 comments

Comments

@Quppa
Copy link
Contributor

Quppa commented Apr 18, 2024

This is an upstream issue in node-id3 v0.2.6, but due to a few hard-coded ID3Version = 3 references, chapter images aren't decoded properly in files with ID3v2.4 tags.

I think the issue might be fixed in the latest code (it's had a big reorganisation since 0.2.6), but unfortunately there's no updated package in npm yet.

I wonder if it's worth trying out node-id3tag, a fork with better ID3v2.4 support, or referencing the latest (unpublished) code from the node-id3 repository somehow. If not, it might be worth adding a warning about ID3v2.4 files to the UI until upstream is updated.

example.zip

@DominikPeters
Copy link
Contributor

Thanks! I've switched to the current code version of node-id3, and your example v2.4 file now appears to be correctly read. I'm not sure what happens on write though. Let me know if something's broken.

@Quppa
Copy link
Contributor Author

Quppa commented Apr 19, 2024

Excellent, thank you.

The exported file is always ID3v2.3. I might open a PR to add a version toggle. There aren't many changes in v2.4 relevant to this tool, but UTF-8 tags are nice (Slack, for example, doesn't like UTF-16 and unfurls MP3 previews as mojibake). Support for v2.4 should be pretty widespread these days - even Windows has supported it since Windows 10 1703.

@DominikPeters
Copy link
Contributor

I just tested node-id3tag and its chapter support appears to be broken (only the last chapter is read). Its commit history ("Prelim support for Chapters") suggests the functionality was never finished.

@DominikPeters
Copy link
Contributor

I reversed the update and went back to the npm version, because the new one had some encoding trouble (in particular, exporting the standard example file that's loaded on startup failed, presumably due to special characters in the train company names).

@DominikPeters DominikPeters reopened this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants