Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support scanning URLs that are not drawn from a sitemap #136

Open
stevejalim opened this issue Jan 24, 2023 · 1 comment
Open

Support scanning URLs that are not drawn from a sitemap #136

stevejalim opened this issue Jan 24, 2023 · 1 comment
Assignees
@stevejalim
Labels
enhancement New feature or request

Comments

@stevejalim
Copy link
Collaborator

With www.m.o there are some URLs which we serve that don't appear in the sitemap for any locale, so don't get checked.

It would be good to add a clause to the allowlist that can specify additional_paths_to_check or similar.

It would need to support both explicit paths and also patterns, (eg /{locale}/firefox/{ver}/whatsnew/) in a way that's sensible to enumerate and also be forward-looking (so we don't have to retrospectively add the latest What's New Page each release)

Please suggest paths to explore in the comments below. Cheers!
@stevejalim stevejalim added the enhancement New feature or request label Jan 24, 2023
@alexgibson
Copy link
Member

As @pmac said on Slack, this should cover most URLs I think: https://github.com/mozilla/bedrock/blob/main/bedrock/settings/base.py#L433

@alexgibson alexgibson removed their assignment Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevejalim stevejalim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevejalim @alexgibson