Implementation of voice call message activation

[maruthi12]

hey guys.......i tried to register using sms for more than 10 times....and i 'm fed up as the code is not received.......can u add the voice code registering feature.......

[duesenfranz]

@willyaranda I'd like to work on this, but I guess it might clash with #64.

Can you give a rough estimation about #64? ☀️

[willyaranda]

I want to merge today (with maybe some changes).

Please, work on top of your PR.

[duesenfranz]

I would propose that a button appears on the number-confirmation-screen after an error occurs, and additionally to the code-confirmation-screen.

For the code-confirmation-screen: should the button be instantly clickable or just after some timeout?
(this is how connectA2 handles this)

[willyaranda]

@duesenfranz I think it's better on the PIN screen. With something like: "If you do not receive the code in the following 5 minutes, click here, and WhatsApp will call you with the PIN".

[duesenfranz]

@willyaranda thats what I meant with code-confirmation-screen :)
But I'd say that instead of such a long text, we have a timer / progress bar or something?

[willyaranda]

Yeah, that is interesting...

A countdown from 1 minute, and then enable a "Call me" button.

[duesenfranz]

Maybe something like the progress bar on this page above or below the button?

Edit: like this:

[willyaranda]

I would prefer a simple countdown

[duesenfranz]

Just a small update:

I got it running with this commit, it's not ready for a PR yet.

(note that this requires this change to be applied to coseme)

How it would look right now:

[duesenfranz]

@willyaranda sorry I didn't see your comment yet...

Do you mean within the button, instead of "Call me!"? Or below the button?

[Timmaks]

@duesenfranz i like your design with the progress bar

[willyaranda]

Could you please put a horizontal bar or something to separate both parts of the screen? We understand what is that progress bar, but maybe a user doesn't :)

[duesenfranz]

@Timmaks @willyaranda

Yeah I agree that it isn't clear they belong together the way it is, what about this:

[willyaranda]

Yeah, better

[Timmaks]

I don't like the bar combined with the button. A2 has a countdown screen with a time in seconds, does you know where that time comes from?

The progress bar in your first design is in my opinion related to the wait time of receiving the sms. If that doesn't come you can request a call.

[Timmaks]

But the opinion of @willyaranda preponderate :)

[willyaranda]

@Timmaks no :) I'm not a UX/UI expert

on Android, there is a 5 minute countdown (with a progress bar?), maybe ConnectA2 do that.

[duesenfranz]

@Timmaks A2 also has a simple countdown from (I think) two minutes.

WA only lets you request a call after ~2 minutes, otherwise it fails with too_early.

@willyaranda
I also can include a timer if you want, that would look something like this I guess:

That said, I like it much more without the timer, it seems overloaded to me otherwise ☀️

[duesenfranz]

@willyaranda which design do you prefer? Otherwise I'm pretty much ready for a PR ☀️

[willyaranda]

No timer :)

[Timmaks]

I would suggest no timer and hide the blue Progressbar as soon the button is active.

[willyaranda]

@duesenfranz check mozillahispano/coseme#8

[duesenfranz]

@willyaranda wow nice ☀️

Altough note that new tokenData is older that the one we had ;)

[willyaranda]

True! I don't know if that's a problem… or not… Could you make a PR to get the old (new, actually) values back? I can only merge from here.

[duesenfranz]

I don't think it's that important, I'll send a PR when I have time ☀️