Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce informative CI jobs covering nodejs experimental versions #3015

Open
rpl opened this issue Jan 12, 2024 · 0 comments
Open

Re-introduce informative CI jobs covering nodejs experimental versions #3015

rpl opened this issue Jan 12, 2024 · 0 comments

Comments

@rpl
Copy link
Member

rpl commented Jan 12, 2024

The CI job build-nodejs-experimental has been changed in #3014 to make it not strict on unit tests failures to unblock updating the CI job to remove the old nodejs 16 and add nodejs 20.

The failures currently hit by the job running on nodejs v21 looks very likely new issues with mocking ESM modules, and so it may be reasonale to assume they need to be fixed in the testdouble custom ESM module loader (as it was for the failures previous hit on nodejs v20 and fixed in testdouble 3.18.0 / quibble 0.7.0).

When we will bring a CI job for nodejs experimental versions we want to make it only informative (to let us prepare to investigate issues that are only hit on nodejs experimental versions while it has not reached stability yet) and not blocking releasing new web-ext versions.

Circle CI doesn't seem to include any feature to allow failing tests to be reported as warnings, and so in the short term we kept the experimental job but made it less strict, that isn't great because the failures would not be visible unless we explicitly look to the CI job logs and so when we will look into bringing back a CI job for the nodejs experimental versions we want to consider other options that may improve the visibility of those failures without making them blocking as it used to be (e.g. we could consider introducing a github action job for the nodejs experimental versions).

@rpl rpl changed the title Enable nodejs v21 CI job Re-introduce informative CI jobs covering nodejs experimental versions Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant