Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx http2 in listen-Directive is obsolete #239

Closed
StefanWetterActiware opened this issue Apr 9, 2024 · 1 comment · Fixed by #252
Closed

nginx http2 in listen-Directive is obsolete #239

StefanWetterActiware opened this issue Apr 9, 2024 · 1 comment · Fixed by #252
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@StefanWetterActiware
Copy link

Hello,

you generate for modern nginx:

# generated 2024-04-09, Mozilla Guideline v5.7, nginx 1.17.7, OpenSSL 1.1.1k, modern configuration, no HSTS, no OCSP
# https://ssl-config.mozilla.org/#server=nginx&version=1.17.7&config=modern&openssl=1.1.1k&hsts=false&ocsp=false&guideline=5.7
server {
    listen 443 ssl http2;
    listen [::]:443 ssl http2;
    ...}

This is obsolete.
Should be:

server {
    listen 443 ssl;
    listen [::]:443 ssl;
    http2 on;
    ...}

See https://nginx.org/en/docs/http/ngx_http_v2_module.html

@StefanWetterActiware StefanWetterActiware changed the title nginx http2 in listen is obsolete nginx http2 in listen-Directive is obsolete Apr 9, 2024
@janbrasna
Copy link
Collaborator

Thanks for noticing. This is a duplicate of #210 and has been resolved in #207 already.

The only issue is that the default nginx template view doesn't use the present-day version number — but if you put in any recent version that you might use, e.g.: 1.25.5, you'll see it's the current syntax.

This will fix itself eventually, when an update using either 1.25.5 or 1.26.x as the default version for the form is released here.

@janbrasna janbrasna added the duplicate This issue or pull request already exists label Oct 5, 2024
@janbrasna janbrasna self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants