-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes requested for Caddy #222
Comments
github: closes mozilla#222
@gene1wood @janbrasna I agree with @francislavoie that the config should be much simpler since Caddy defaults and Go TLS library defaults are solid. I have submitted #261 with a much simpler config, though I have retained the ciphers specification for the moment due to prior historical discussions. I hope that Mozilla will update the specs and that we discuss preferring to use practical, common sense, and secure settings from apps such as Caddy and lighttpd which provide secure settings, rather than pedantically trying to shoehorn configurations to match specifications, which may reduce security and may be outdated. |
github: closes mozilla#222
This comment was marked as resolved.
This comment was marked as resolved.
Other than that — if there is a spec condition that can't be satisfied by the product, a comment pointing it out is just fine to make sure consumers know what to expect (and we will be adding a lot of those as products remove the ability to do stupid things even for those who have a reason to;D). |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@gstrauss It attracts a different group of interested parties; there are consumers of the specs who are not consumers of the configs here so are not part of the discussions here, but should have the visibility into the topics over there. (New ownership is promised from MoCo Security Assurance if I understood it right. Once set up, I believe we'll be in sync a lot more, upstreaming some changes that we collect here…) I would like to avoid having to discuss "meta" topics in every single PR or issue, so within a few weeks I'll start raising those general themes either as issues, or discussion posts, we'll see what works better… Until then, I'll just resort to "TBD" of sorts not having to fish for the info across dozens of tickets when time comes for collecting all of that into one single thread. TL;DR: The content of configs change. Features should trigger a "not supported" errors instead of basing that on "name" of config etc. Whether something should be omitted or not is decided elsewhere, and I'll open the discussion about how to handle the defaults where the authors want their defaults instead of the guideline data (aside from removing the server from the tool, or capping the versions for which we return the configs to some older-only, that needed it, and just showing a message explaining that situation for current versions).
This was a bug, fixed now, disabling the input for servers not using it.
Anyone can submit PRs updating server versions. We usually only bump them when making changes to the actual logic, i.e. when new versioning conditions need to be added or something fixed.
Nothing is being recommended, only folks can manually generate outputs for any version that was ever supported and not explicitly removed, by manually changing the input value, or following a permalink. As long as there's no extra effort to keep the logic in, it stays. It's never presented to anyone, only the most recent configured version. Some of the topics were spun out to separate issues, some will warrant a broader discussion. Also, for the laughs: #3 (Caddy was mentioned years ago as the reason to actually disable any recommendation selection etc. in favour of its defaults;D) |
From the server authors:
— Originally posted in #153 by @francislavoie
The text was updated successfully, but these errors were encountered: