-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config for old client (TLS 1.0 / 1.1) won't work, for (at least) HAProxy 2.4. #206
Comments
@lvergergsk When you use the config that you link to in HAProxy, does HAProxy throw an error (can you share what the error is if it does)? Can you tell me more about the |
@gene1wood
To clearfy, the point I intend to make is following: I added |
Actually |
It was buggy before 2.2 haproxy/haproxy@2e8d52f see haproxy/haproxy#595 — so the question is… if that gets changed to ssl-min/max-ver, should that be behind haproxy version conditional, or such bug in the server should not be polluting the config definition? (Thing is… if the configuration doesn't get picked up, is it safe to provide it as a recommendation?) EDIT: Oh it's a v2.0+ feature only IIRC anyways, so it has to be defined behind a version check:/ similar to 342242c — so I'd make the split at v2.2 to render How much work should go into fixing |
@lvergergsk What you're suggesting to force-enable TLSv1.1-v1.2 is to change the configs (for 2.0+ or 2.2+ see above) along the lines: # intermediate configuration
- ssl-default-bind-options prefer-client-ciphers no-sslv3 no-tlsv10 no-tlsv11 no-tls-tickets
+ ssl-default-bind-options prefer-client-ciphers no-tls-tickets ssl-min-ver TLSv1.2
- ssl-default-server-options no-sslv3 no-tlsv10 no-tlsv11 no-tls-tickets
+ ssl-default-server-options no-tls-tickets ssl-min-ver TLSv1.2 (↑ this one has no impact, but needs v2+) # old configuration
- ssl-default-bind-options no-sslv3 no-tls-tickets
+ ssl-default-bind-options no-tls-tickets ssl-min-ver TLSv1.0
- ssl-default-server-options no-sslv3 no-tls-tickets
+ ssl-default-server-options no-tls-tickets ssl-min-ver TLSv1.0 to force lower TLS version than current default to cater to |
HandleBar is somewhat deficient as a template parser as HandleBar does not cleanly support compound conditional logic without duplication of contents. |
https://ssl-config.mozilla.org/#server=haproxy&version=2.4&config=old&openssl=1.1.1k&guideline=5.7
Comparing
intermediate
config withold
config, you removedno-tlsv10 no-tlsv11
, but this actually does not allowTLS 1.0
andTLS 1.1
. You will need to addssl-min-ver TLSv1.0
for this to work.You can try it use
curl --tlsv1.0 --tls-max 1.0 ...
The text was updated successfully, but these errors were encountered: