Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What Template SHOULD be able to do #10

Closed
9 tasks done
gregglind opened this issue Oct 12, 2016 · 8 comments · Fixed by #73
Closed
9 tasks done

What Template SHOULD be able to do #10

gregglind opened this issue Oct 12, 2016 · 8 comments · Fixed by #73

Comments

@gregglind
Copy link
Contributor

gregglind commented Oct 12, 2016

Running list of the GUARANTEES you should get from using the template.

  • All files lint
  • testing
  • dependency checks for all modules Doesn't catch missing, but code coverage does
  • consistent package.json (fixpack)
  • continuous integration <- TRAVIS ONLY
  • shrinkwrap
  • code coverage
  • addon-linter
  • nsp
@gregglind
Copy link
Contributor Author

@pdehaan thoughts? Other contract? Add them if so!

@gregglind
Copy link
Contributor Author

  • depcheck still stinks.
  • ci is unclear
  • need to finish up tests for 100% coverage of the basic addon

@pdehaan
Copy link
Contributor

pdehaan commented Oct 12, 2016

Yeah, depcheck and similar are still awkward when we do things like require('chrome') and require('sdk') for add-ons stuff. https://github.com/mcasimir/depcheck-ci seems a bit better, but still uses depcheck under the hood.

Only other ones I could think of is integrating addons-linter and nsp.

@gregglind
Copy link
Contributor Author

I claim all of these now work, for some values of work.

@gregglind
Copy link
Contributor Author

Is it worth doing Circle CI and / or doing something different to catch the 'missing' keys?

Filed at: mcasimir/depcheck-ci#2

@gregglind
Copy link
Contributor Author

TODO: update this bug for hte new template.

@motin
Copy link
Contributor

motin commented Jun 20, 2018

These (except possibly dependency checking) are all covered in the new web extension based template.

@motin
Copy link
Contributor

motin commented Mar 2, 2019

Closing since #73 is merged

@motin motin closed this as completed Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants