Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results Page: Allow users to change the page title of PerfCompare and have the title persist in the url #769

Open
Carla-Moz opened this issue Oct 8, 2024 · 9 comments · May be fixed by #774

Comments

@Carla-Moz
Copy link
Contributor

Carla-Moz commented Oct 8, 2024

Description: As a user, I want to be able to change the title of PerfCompare and have the new title persist in the url, so that I can share the updated title with others.

Steps to Reproduce:

  1. Read the PerfCompare Documentation to get familiar with the app.
  2. Navigate to the title section of the PerfCompare results: ResultsPage
  3. Observe that there is currently no option to modify the title and have it persist in the URL.

image

Acceptance Criteria:

  1. The title should be editable by the user.
  2. The new title should persist in the URL so that it is retained after a page refresh.
  3. When a user shares the URL with others, the custom title should be displayed.
  4. The url should have the updated page title.

Hint!
Check out this closed PR to help you out. Persist the search term in the url #724

@FatumaA
Copy link

FatumaA commented Oct 8, 2024

Hi,
I'd like to attempt this

@Carla-Moz
Copy link
Contributor Author

@FatumaA, Please go ahead and try.

@syedbarimanjan
Copy link

@Carla-Moz what do you mean by the title?

@hibaa03
Copy link

hibaa03 commented Oct 9, 2024

Hi! I've implemented functionality when I enter a custom title in the input field, it updates the URL correctly and when i refresh the page, it persists.
If I share the URL, the custom title is displayed as intended and the title is in the URL as well, as for me locally it shows (http://localhost:3000/compare-results?baseRev=aa73934529cc8e33ed70fd861d70456fdf7f0818&baseRepo=try&framework=1&**title=updated+title**)

However, when navigating back to the Results page from the home page, the previously entered title is not retained, and the title reverts to a default value.

My question is, Is this behavior expected, or should the custom title persist across navigations? If it's expected to retain the custom title, what changes would be necessary?

@syedbarimanjan
Copy link

Hi! I've implemented functionality when I enter a custom title in the input field, it updates the URL correctly and when i refresh the page, it persists. If I share the URL, the custom title is displayed as intended and the title is in the URL as well, as for me locally it shows (http://localhost:3000/compare-results?baseRev=aa73934529cc8e33ed70fd861d70456fdf7f0818&baseRepo=try&framework=1&**title=updated+title**)

However, when navigating back to the Results page from the home page, the previously entered title is not retained, and the title reverts to a default value.

My question is, Is this behavior expected, or should the custom title persist across navigations? If it's expected to retain the custom title, what changes would be necessary?

Yes i think so that this is the expected behavior as stated here.

@FatumaA
Copy link

FatumaA commented Oct 9, 2024

Hi Carla,
I've linked my first attempt at this. Please let me know if that was what was meant and looking forward to your review

@claire256
Copy link

claire256 commented Oct 10, 2024

Hello, @Carla-Moz ,What title are you referring to?
Did you mean this?
Screenshot from 2024-10-10 20-42-45

@hibaa03
Copy link

hibaa03 commented Oct 10, 2024

@claire256 from what I know, this is what page title is image

@claire256
Copy link

@hibaa03 , thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants