Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results Page: Persist the column filters in the results table in the url #765

Open
Carla-Moz opened this issue Oct 8, 2024 · 4 comments · May be fixed by #786
Open

Results Page: Persist the column filters in the results table in the url #765

Carla-Moz opened this issue Oct 8, 2024 · 4 comments · May be fixed by #786

Comments

@Carla-Moz
Copy link
Contributor

Carla-Moz commented Oct 8, 2024

Description: As a user, when I try to filter the platform, status, or confidence in the results table by using the column filters, I expect the filtered view to be retained when I refresh the page. However, currently, the filters are not persisted, and the default view is restored upon refreshing.

Steps to Reproduce:

  1. Read the PerfCompare Documentation to get familiar with the app.
  2. Navigate to the results table: Results
  3. Apply filters to the columns (e.g., show only improvements or regressions or by platform or confidence).
  4. Refresh the page.
  5. Observe that the column filters are not persisted, and the default view is shown.

Acceptance Criteria:

  1. Column filters should persist in the URL so that the exact same filtered view is retained after a page refresh.
  2. When a user shares the filtered view URL with others, they should see the same filtered results.
  3. The URL should update as filters are applied or removed.

image

image

Hint!
Check out this closed PR to help you out. Persist the search term in the url #724

@Carla-Moz Carla-Moz changed the title Results Page: Persist the column filters in the results table in the url Results Page: Persist the column status filters in the results table in the url Oct 8, 2024
@syedbarimanjan
Copy link

syedbarimanjan commented Oct 8, 2024

Hi I would like to work on this. Do i need to wait for it to be assigned or should i start working on it right away.

@Carla-Moz
Copy link
Contributor Author

@syedbarimanjan yes, go ahead and try it out! You don't need to wait to be assigned.

@Netacci
Copy link

Netacci commented Oct 8, 2024

@Carla-Moz Should this be implemented for only status and not platform and confidence? or is that a separate issue?

@Carla-Moz Carla-Moz changed the title Results Page: Persist the column status filters in the results table in the url Results Page: Persist the column filters in the results table in the url Oct 8, 2024
@Carla-Moz
Copy link
Contributor Author

Carla-Moz commented Oct 8, 2024

@Netacci Good question! Yes, this should be implemented for status, platform, and confidence. I've updated the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants