From f1f58bbe6796cf48d863ccddb59c6ffbb1f21e50 Mon Sep 17 00:00:00 2001 From: Tim van der Meij Date: Tue, 30 Jul 2024 18:35:12 +0200 Subject: [PATCH] Give all HTML button elements a type The HTML button elements we use are all regular buttons that don't submit form data to a server. According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#notes those buttons should all have their type set to `button` explicitly, but we only do that a handful of them. This commit fixes the issue by consistently giving all our buttons the `button` type. Co-authored-by: Calixte Denizet --- examples/learning/prevnext.html | 4 +- examples/mobile-viewer/viewer.html | 8 +- extensions/chromium/options/options.html | 2 +- web/viewer-geckoview.html | 6 +- web/viewer.html | 96 ++++++++++++------------ 5 files changed, 58 insertions(+), 58 deletions(-) diff --git a/examples/learning/prevnext.html b/examples/learning/prevnext.html index 40c1488c8b99d..e1043bf1e8fad 100644 --- a/examples/learning/prevnext.html +++ b/examples/learning/prevnext.html @@ -9,8 +9,8 @@

'Previous/Next' example

- - + +     Page: /
diff --git a/examples/mobile-viewer/viewer.html b/examples/mobile-viewer/viewer.html index 50bbfd7811411..6bd8b540647be 100644 --- a/examples/mobile-viewer/viewer.html +++ b/examples/mobile-viewer/viewer.html @@ -43,13 +43,13 @@

- - + + - - + +
diff --git a/extensions/chromium/options/options.html b/extensions/chromium/options/options.html index 8d5661fcbdc3b..78385926fc98f 100644 --- a/extensions/chromium/options/options.html +++ b/extensions/chromium/options/options.html @@ -31,7 +31,7 @@
- +