From ee7441d5bc0baf8ca34b95128811785446a2c3c8 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Thu, 15 Aug 2024 13:33:13 +0200
Subject: [PATCH] Shorten the `PDFViewerApplication._parseHashParams` method

The way that the debugging hash-parameter parsing is implemented leads to a lot of boilerplate code in this method, since *most* of the cases are very similar.[1]
With just a few exceptions most of the options can be handled automatically, by defining an appropriate checker for each option.

---

[1] With the recent introduction of TESTING-only options the size of this method increased a fair bit.
---
 web/app.js | 90 +++++++++++++++++-------------------------------------
 1 file changed, 28 insertions(+), 62 deletions(-)

diff --git a/web/app.js b/web/app.js
index 2cf98b917563a..82a60be07ca28 100644
--- a/web/app.js
+++ b/web/app.js
@@ -285,6 +285,7 @@ const PDFViewerApplication = {
       this._PDFBug = PDFBug;
     };
 
+    // Parameters that need to be handled manually.
     if (params.get("disableworker") === "true") {
       try {
         GlobalWorkerOptions.workerSrc ||= AppOptions.get("workerSrc");
@@ -298,30 +299,6 @@ const PDFViewerApplication = {
         console.error(`_parseHashParams: "${ex.message}".`);
       }
     }
-    if (params.has("disablerange")) {
-      AppOptions.set("disableRange", params.get("disablerange") === "true");
-    }
-    if (params.has("disablestream")) {
-      AppOptions.set("disableStream", params.get("disablestream") === "true");
-    }
-    if (params.has("disableautofetch")) {
-      AppOptions.set(
-        "disableAutoFetch",
-        params.get("disableautofetch") === "true"
-      );
-    }
-    if (params.has("disablefontface")) {
-      AppOptions.set(
-        "disableFontFace",
-        params.get("disablefontface") === "true"
-      );
-    }
-    if (params.has("disablehistory")) {
-      AppOptions.set("disableHistory", params.get("disablehistory") === "true");
-    }
-    if (params.has("verbosity")) {
-      AppOptions.set("verbosity", params.get("verbosity") | 0);
-    }
     if (params.has("textlayer")) {
       switch (params.get("textlayer")) {
         case "off":
@@ -359,46 +336,35 @@ const PDFViewerApplication = {
       AppOptions.set("localeProperties", { lang: params.get("locale") });
     }
 
+    // Parameters that can be handled automatically.
+    const opts = {
+      disableAutoFetch: x => x === "true",
+      disableFontFace: x => x === "true",
+      disableHistory: x => x === "true",
+      disableRange: x => x === "true",
+      disableStream: x => x === "true",
+      verbosity: x => x | 0,
+    };
+
     // Set some specific preferences for tests.
     if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("TESTING")) {
-      if (params.has("highlighteditorcolors")) {
-        AppOptions.set(
-          "highlightEditorColors",
-          params.get("highlighteditorcolors")
-        );
-      }
-      if (params.has("maxcanvaspixels")) {
-        AppOptions.set(
-          "maxCanvasPixels",
-          Number(params.get("maxcanvaspixels"))
-        );
-      }
-      if (params.has("supportscaretbrowsingmode")) {
-        AppOptions.set(
-          "supportsCaretBrowsingMode",
-          params.get("supportscaretbrowsingmode") === "true"
-        );
-      }
-      if (params.has("spreadmodeonload")) {
-        AppOptions.set(
-          "spreadModeOnLoad",
-          parseInt(params.get("spreadmodeonload"))
-        );
-      }
-      if (params.has("enablealttext")) {
-        AppOptions.set("enableAltText", params.get("enablealttext") === "true");
-      }
-      if (params.has("enableupdatedaddimage")) {
-        AppOptions.set(
-          "enableUpdatedAddImage",
-          params.get("enableupdatedaddimage") === "true"
-        );
-      }
-      if (params.has("enableguessalttext")) {
-        AppOptions.set(
-          "enableGuessAltText",
-          params.get("enableguessalttext") === "true"
-        );
+      Object.assign(opts, {
+        enableAltText: x => x === "true",
+        enableGuessAltText: x => x === "true",
+        enableUpdatedAddImage: x => x === "true",
+        highlightEditorColors: x => x,
+        maxCanvasPixels: x => parseInt(x),
+        spreadModeOnLoad: x => parseInt(x),
+        supportsCaretBrowsingMode: x => x === "true",
+      });
+    }
+
+    for (const name in opts) {
+      const check = opts[name],
+        key = name.toLowerCase();
+
+      if (params.has(key)) {
+        AppOptions.set(name, check(params.get(key)));
       }
     }
   },