From 2c90eee5a877c6a71c844e836f17690f19c43b67 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Tue, 5 Nov 2024 13:55:13 +0100
Subject: [PATCH] Shorten a few helper functions in `src/core/core_utils.js`

In a few cases we can ever so slightly shorten the code without negatively impacting the readability.
---
 src/core/core_utils.js | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/src/core/core_utils.js b/src/core/core_utils.js
index 58c721f387283..96612c4e9d995 100644
--- a/src/core/core_utils.js
+++ b/src/core/core_utils.js
@@ -166,14 +166,13 @@ function toRomanNumerals(number, lowerCase = false) {
     "The number should be a positive integer."
   );
   const romanBuf = [];
-  let pos;
   // Thousands
   while (number >= 1000) {
     number -= 1000;
     romanBuf.push("M");
   }
   // Hundreds
-  pos = (number / 100) | 0;
+  let pos = (number / 100) | 0;
   number %= 100;
   romanBuf.push(ROMAN_NUMBER_MAP[pos]);
   // Tens
@@ -191,10 +190,7 @@ function toRomanNumerals(number, lowerCase = false) {
 // native function in the sense that it returns the ceiling value and that it
 // returns 0 instead of `Infinity`/`NaN` for `x` values smaller than/equal to 0.
 function log2(x) {
-  if (x <= 0) {
-    return 0;
-  }
-  return Math.ceil(Math.log2(x));
+  return x > 0 ? Math.ceil(Math.log2(x)) : 0;
 }
 
 function readInt8(data, offset) {
@@ -573,13 +569,10 @@ function recoverJsURL(str) {
 
   const jsUrl = regex.exec(str);
   if (jsUrl?.[2]) {
-    const url = jsUrl[2];
-    let newWindow = false;
-
-    if (jsUrl[3] === "true" && jsUrl[1] === "app.launchURL") {
-      newWindow = true;
-    }
-    return { url, newWindow };
+    return {
+      url: jsUrl[2],
+      newWindow: jsUrl[1] === "app.launchURL" && jsUrl[3] === "true",
+    };
   }
 
   return null;