Skip to content

Commit

Permalink
ci: fix cache-hit check (#2186)
Browse files Browse the repository at this point in the history
According to the actions/cache docs an empty string represents a cache miss:

> cache-hit - A string value to indicate an exact match was found for the key.
>  - If there's a cache hit, this will be 'true' or 'false' to indicate if there's an exact match for key.
>  - If there's a cache miss, this will be an empty string.

https://github.com/actions/cache?tab=readme-ov-file#outputs

Previously Neqo's CI would check for `"false"`, now it checks for `""`.
  • Loading branch information
mxinden authored Oct 17, 2024
1 parent ce1e79f commit 62415bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/actions/nss/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ runs:
if: env.USE_SYSTEM_NSS == '0'
shell: bash
run: |
if [ "${{ runner.environment }}" != "github-hosted" ] || [ "${{ steps.cache.outputs.cache-hit }}" == "false" ]; then
if [ "${{ runner.environment }}" != "github-hosted" ] || [ "${{ steps.cache.outputs.cache-hit }}" == "" ]; then
echo "Building NSS from source"
echo "BUILD_NSS=1" >> "$GITHUB_ENV"
else
Expand Down

0 comments on commit 62415bf

Please sign in to comment.