-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAC leaves behind tabs which are discarded-on-creation, but are reopened in a container #2619
Comments
This does seem to help. However, I don't understand or agree with your conclusion here:
The original behavior is pretty clearly unexpected and surprising. It seems to me to be a pretty poor user experience to require people to change an option they don't know about to get correct behavior (i.e. proper replacement of tabs). So I'm going to leave this open for now. |
I'm hitting a similar issue -- perhaps related to auto tab discard extension https://webextension.org/listing/tab-discard.html. Steps to reproduce:
I confirmed that the preference to "Replace tab instead of creating a new one" does sidestep the problem... but from what I understand it will have unwanted side effects for other use cases like clicking a link in an already-loaded page that should load in a different container. |
It seems like we could handle discarded tabs better. Either by remembering the container they were originally using (ideal), or by always triggering the "replace tab" behavior even if the preference wasn't set. |
Before submitting a bug report
Step to reproduce
await browser.tabs.create({url: 'https://example.com/', discarded: true})
Actual behavior
MAC will notice the tab, and immediately create a new container tab which loads the URL immediately (as expected). However, the tab created in step (2) that is not in a container sometimes—but not always—is left open. That is to say, MAC does not clean up/close this tab, so there are two tabs pointing at the same URL—one in a container, and one not in a container.
The tab not in a container is never actually loaded, however—it's just a blank page. (So this does not appear to be a security issue as such.)
Expected behavior
I expected MAC to close the tab created in step (2) once the new container tab was created.
Additional informations
Some browser extensions will create tabs that are discarded—for example, Tab Stash does this to avoid triggering the loading of too many tabs at once (which may cause performance problems).
This bug causes some bad effects that are noticed by Tab Stash users, for example: josh-berry/tab-stash#425
Provide a copy of Troubleshooting Information page (optional)
No response
The text was updated successfully, but these errors were encountered: