Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel analysis matches *any* sequence of events if no event matches #279

Open
wlach opened this issue Oct 20, 2021 · 0 comments
Open

Funnel analysis matches *any* sequence of events if no event matches #279

wlach opened this issue Oct 20, 2021 · 0 comments
Labels
bug Something isn't working Events Issues or enhancements to the events explores

Comments

@wlach
Copy link
Contributor

wlach commented Oct 20, 2021

A funnel analysis like this, which looks at an event with category "foo" and an event "bar" (which obviously doesn't exist) says that every single client matches the event analysis:

https://mozilla.cloud.looker.com/explore/fenix/funnel_analysis?toggle=fil&qid=5qTHsyiW6boprm8tBOg4qp

This is a bit of a gotcha when using the explore, so we should fix it.

Underneath the hood, the funnel analysis explore uses event_analysis.aggregate_match_strings, which returns an empty string '' in the case that there is no input (which obviously anything will match). The simplest fix is probably to change the funnel analysis explore to match a short regular expression that will never occur in events_daily like ^,$ for this case. I think you'd probably want to do this around here:

@wlach wlach added Events Issues or enhancements to the events explores Glean Changes for Glean Pings and automated Glean derived tables and removed Glean Changes for Glean Pings and automated Glean derived tables labels Dec 16, 2021
@sean-rose sean-rose added the bug Something isn't working label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Events Issues or enhancements to the events explores
Projects
None yet
Development

No branches or pull requests

2 participants