Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show y=0 unless there is a data point near y=0 #37

Closed
openjck opened this issue Feb 27, 2018 · 2 comments
Closed

Don't show y=0 unless there is a data point near y=0 #37

openjck opened this issue Feb 27, 2018 · 2 comments

Comments

@openjck
Copy link
Contributor

openjck commented Feb 27, 2018

Su brought this up in Slack.

Some charts look essentially flat when they aren't because y=0 is shown whether or not there is a data point at y=0. We should just be aware that changing this will exaggerate any trends, including downward trends, whether temporary or otherwise.

@openjck openjck changed the title Don't always show 0 on the y axis Don't show y=0 unless there is a data point at y=0 Feb 27, 2018
@openjck
Copy link
Contributor Author

openjck commented Feb 27, 2018

Unfortunately, I can't seem to find a good way to achieve this right now. There's a bug in metrics-graphics that creates lots of empty space above the line when y=0 is not shown, which makes the line appear relatively flat and thus defeats the purpose of omitting y=0. Also, using max_y as a workaround causes parts of the line to become invisible.

@openjck
Copy link
Contributor Author

openjck commented Mar 2, 2018

It may be possible to work around this.

@openjck openjck changed the title Don't show y=0 unless there is a data point at y=0 Don't show y=0 unless there is a data point near y=0 Mar 2, 2018
@openjck openjck closed this as completed in 9663f87 Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant