Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing instructions on how to get/create the add-on #1028

Closed
jwatt opened this issue Jul 22, 2021 · 7 comments
Closed

Consider providing instructions on how to get/create the add-on #1028

jwatt opened this issue Jul 22, 2021 · 7 comments
Assignees

Comments

@jwatt
Copy link

jwatt commented Jul 22, 2021

It would be helpful if the docs had some information on where to get the add-on from (or else note that there is no such place, currently) and how to build and install the add-on. There's nothing on:

https://github.com/mozilla/code-coverage/blob/master/README.md
https://github.com/mozilla/code-coverage/blob/master/addon/README.md

@marco-c marco-c self-assigned this Jul 27, 2021
@marco-c
Copy link
Collaborator

marco-c commented Jul 27, 2021

I've added a link to https://addons.mozilla.org/it/firefox/addon/gecko-code-coverage/ in both READMEs.

@marco-c
Copy link
Collaborator

marco-c commented Jul 27, 2021

@jwatt
Copy link
Author

jwatt commented Jul 27, 2021

Ah, so I was aware of that AMO page, but it says the add-on's last updated was over two years ago and its 'Homepage' link links to https://github.com/mozilla/code-coverage-addon , which was archived around the same time. There have been a significant number of updates to the copy of the add-on in this repo since then, so I assumed the copy in this repo must be published elsewhere.

Can you update the 'Homepage' link on that AMO page to link to this repository (presumably https://github.com/mozilla/code-coverage/blob/master/addon/README.md)? And is there any prospect of the published add-on getting an update any time soon?

@marco-c
Copy link
Collaborator

marco-c commented Jul 28, 2021

Can you update the 'Homepage' link on that AMO page to link to this repository (presumably https://github.com/mozilla/code-coverage/blob/master/addon/README.md)?

Done!

And is there any prospect of the published add-on getting an update any time soon?

I will update it. I don't know if it still works to be honest, but I hope so :)

@marco-c
Copy link
Collaborator

marco-c commented Jul 28, 2021

I think it doesn't work anymore :(

I've filed #1039.

Unfortunately I won't have time to investigate this anytime soon.

@jwatt
Copy link
Author

jwatt commented Jul 28, 2021

That's a shame. Thanks for updating the link and checking whether things still work though. :-)

@marco-c
Copy link
Collaborator

marco-c commented Jul 28, 2021

At least Searchfox integration is now built-in :)
And similarly with Phabricator (but only on the after part of the patches, and only after they land in m-c).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants