Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delegate review actions to CinderActions #1982

Open
eviljeff opened this issue Jan 26, 2024 · 1 comment · May be fixed by mozilla/addons-server#23004
Open

delegate review actions to CinderActions #1982

eviljeff opened this issue Jan 26, 2024 · 1 comment · May be fixed by mozilla/addons-server#23004
Assignees
@eviljeff
Labels
component:reviewer_tools repository:addons-server Issue relating to addons-server

Comments

@eviljeff
Copy link
Member

eviljeff commented Jan 26, 2024 •
edited
Loading

Currently we carry out the review actions of, for example, disabling an add-on by:

  • in the reviewer tools call force_disable
  • and then call a task which notifies the cinder API of the decision, while sending out notification emails

This means we have duplicated places where we carry out the "disable addon" action, when for consistency it should be a single place.

┆Issue is synchronized with this Jira Task
@KevinMind
Copy link
Contributor

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-671

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 3, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 3, 2024
@eviljeff eviljeff mentioned this issue Jan 10, 2025
Merged
5 tasks
This was referenced Jan 21, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eviljeff eviljeff

Labels
component:reviewer_tools repository:addons-server Issue relating to addons-server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delegate review actions to cinder eviljeff/olympia
3 participants
@diox @eviljeff @KevinMind