-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review overall performances #206
Comments
We should be able to re-use our entire font logic from the frontend: use a subset + fallback with different unicode-range and proper ordering set, optionally preloading the subset if we feel displaying text as early as possible is worth it. |
Note: for the font strategy in particular, we would need to adjust the weights because of mozilla/addons#14160 |
Main takeways:
|
Thanks!
Could you help with that? The blog is
With a
We could, potentially, but that will depend on the long-term strategy I believe. One idea I had was to crawl the content we fetch on WP, download the assets, rewrite the URLs (we do this already for some) at build time, so that we can push everything to S3. OTOH that's a recipe for disaster so maybe we can come up with something else.
I thought WP would do it to be honest. If not, I think we'll have to tell Editorial about it. |
Fonts have been updated to fix #245, so we're good here now. The two remaining items are:
|
If we implement mozilla/addons#9562, we won't need this. |
This blog is statically generated, hosted on s3 "website" with caching configured, and there is a nginx proxy in front, which has its own cache as well.
We don't have a lot of css and js, although some css is borrowed from addons-frontend and it isn't optimized.
I did some tests and there is no major issue on -dev/-stage. Once we have realistic content, we should do a quick perf audit to see if this project needs some tweaks.
@diox said we could look at the fonts. We can probably make sure we're using a fairly small font given that content is en-US only. Inter should provide such a font (latin?).
Optimizing the css coming from addons-frontend is already captured in a separate issue.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: