Columns and DataType Not Explicitly Set on line 196 of prepare_voxceleb.py

[CodeSmileBot]

Hello!

I found an AI-Specific Code smell in your project.
The smell is called: Columns and DataType Not Explicitly Set

You can find more information about it in this paper: https://dl.acm.org/doi/abs/10.1145/3522664.3528620.

According to the paper, the smell is described as follows:

Problem	If the columns are not selected explicitly, it is not easy for developers to know what to expect in the downstream data schema. If the datatype is not set explicitly, it may silently continue the next step even though the input is unexpected, which may cause errors later. The same applies to other data importing scenarios.
Solution	It is recommended to set the columns and DataType explicitly in data processing.
Impact	Readability

Example:

### Pandas Column Selection
import pandas as pd
df = pd.read_csv('data.csv')
+ df = df[['col1', 'col2', 'col3']]

### Pandas Set DataType
import pandas as pd
- df = pd.read_csv('data.csv')
+ df = pd.read_csv('data.csv', dtype={'col1': 'str', 'col2': 'int', 'col3': 'float'})

You can find the code related to this smell in this link:

TTS/TTS/speaker_encoder/utils/prepare_voxceleb.py

Lines 186 to 206 in a2606fb

	speaker_id_dict[speaker_name] = num
	# wav_filesize = os.path.getsize(wav_file)
	wav_length = len(sf.read(wav_file)[0])
	files.append(
	(os.path.abspath(wav_file), wav_length, speaker_id_dict[speaker_name], speaker_name)
	)
	# Write to CSV file which contains four columns:
	# "wav_filename", "wav_length_ms", "speaker_id", "speaker_name".
	csv_file_path = os.path.join(output_dir, output_file)
	df = pandas.DataFrame(
	data=files, columns=["wav_filename", "wav_length_ms", "speaker_id", "speaker_name"])
	df.to_csv(csv_file_path, index=False, sep="\t")
	logging.info("Successfully generated csv file {}".format(csv_file_path))
	def processor(directory, subset, force_process):
	""" download and process """
	urls = SUBSETS
	if subset not in urls:
	raise ValueError(subset, "is not in voxceleb")

.

I also found instances of this smell in other files, such as:

.

I hope this information is helpful!