Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

[pi] Remove the munger #676

Closed
m8ttyB opened this issue Mar 20, 2018 · 5 comments
Closed

[pi] Remove the munger #676

m8ttyB opened this issue Mar 20, 2018 · 5 comments
Labels
backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. chore

Comments

@m8ttyB
Copy link
Contributor

m8ttyB commented Mar 20, 2018

Task: responsibly remove the munger along with the accompanying touch points this function is used in throughout our page objects.

Note, there is a dependency that we need to wait on, add annotations of our React components to the DOM in dev builds #664. Once this has landed we can move towards using the annotated CSS selectors for the tests to hook into.

@devinreams
Copy link
Contributor

devinreams commented Mar 20, 2018 via email

@jimporter
Copy link
Contributor

I don't think we should actually remove this, but we can move away from using it where possible. We may want to actually check that styles are updating as expected in certain cases.

@m8ttyB
Copy link
Contributor Author

m8ttyB commented Mar 20, 2018

@jimporter good call, I let me change this to "responsibly remove." Admittedly there are other options for ensuring styles are updating as expected that we may want to consider scoping and working into the test suite. The current suite of tests is meant to functionally check the behaviors of LB and not the visual aspects of it.

@m8ttyB
Copy link
Contributor Author

m8ttyB commented Mar 20, 2018

@devinreams It's up for discussion, but I think it's safer for the dev team to implement #664.

@m8ttyB m8ttyB added the backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. label Mar 28, 2018
@m8ttyB
Copy link
Contributor Author

m8ttyB commented Mar 28, 2018

Closing this out. If in the future we want to re-approach this work, we can do so incrementally as the test suite expands.

@m8ttyB m8ttyB closed this as completed Mar 28, 2018
@ghost ghost removed the backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. label Mar 28, 2018
@m8ttyB m8ttyB added backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. and removed needs-pi labels Mar 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. chore
Projects
None yet
Development

No branches or pull requests

3 participants