Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Create shared eslint config for projects and modules #102

Open
devinreams opened this issue Sep 22, 2017 · 3 comments
Open

Create shared eslint config for projects and modules #102

devinreams opened this issue Sep 22, 2017 · 3 comments
Labels

Comments

@devinreams
Copy link
Contributor

devinreams commented Sep 22, 2017

A suggestion from @pdehaan at mozilla-lockwise/lockbox-datastore#34 (review) to consider:

a custom eslint-config-lockbox and/or eslint-plugin-lockbox so you can share ESLint configs between repos for cross repo consistency

@pdehaan
Copy link
Contributor

pdehaan commented Sep 22, 2017

If somebody with GitHub powers can create an empty mozilla-lockbox/eslint-plugin-lockbox, I can take a stab at creating a shared ESLint config (if this is something you want to pursue).

@devinreams
Copy link
Contributor Author

I think it's something we'll want. There is project-specific stuff we'd still need to consider including/excluding. For example "browser" stuff and a11y linitng would not be necessary for the datastore...

https://github.com/mozilla-lockbox/eslint-plugin-mozilla-lockbox

@pdehaan
Copy link
Contributor

pdehaan commented Sep 29, 2017

Initial PR for shared plugin rules at mozilla-lockwise/eslint-plugin-mozilla-lockbox#1.
It was working locally for me, but I had to do a bit of package.json hackery to install from my GitHub PR branch since it hasn't been published to npm, so it may take a bit of fiddling once we get the PR merged and published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants